git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/2] fsck.c: Change the type of fsck_ident()'s first argument

From
Yuxuan Shui <yshuiv7@gmail.com>
Date
Mar 13, 2014, 04:45 UTC
Message-ID
<1394685951-9726-2-git-send-email-yshuiv7@gmail.com>
In-Reply-To
<1394685951-9726-1-git-send-email-yshuiv7@gmail.com>

Since fsck_ident doesn't change the content of **ident, the type of ident could be const char **.

This change is required to rewrite fsck_commit() to use skip_prefix().
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
 fsck.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsck.c b/fsck.c
index 99c0497..7776660 100644
--- a/fsck.c
+++ b/fsck.c
@@ -243,7 +243,7 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
 	return retval;
 }
 
-static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
+static int fsck_ident(const char **ident, struct object *obj, fsck_error error_func)
 {
 	if (**ident == '<')
 		return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email");
@@ -281,7 +281,7 @@ static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
 
 static int fsck_commit(struct commit *commit, fsck_error error_func)
 {
-	char *buffer = commit->buffer;
+	const char *buffer = commit->buffer;
 	unsigned char tree_sha1[20], sha1[20];
 	struct commit_graft *graft;
 	int parents = 0;
-- 
1.9.0
Previous: Yuxuan ShuiNext: Junio C Hamano
Message 2 of 6 in “GSoC micro project, rewrite fsck_commit() to use skip_prefix()”
  1. 0/2 GSoC micro project, rewrite fsck_commit() to use skip_prefix()Yuxuan Shui, Mar 13, 2014
  2. 1/2 fsck.c: Change the type of fsck_ident()'s first argumentYuxuan Shui, Mar 13, 2014
  3. Junio C HamanoMar 13, 2014
  4. 2/2 fsck.c: Rewrite fsck_commit() to use skip_prefix()Yuxuan Shui, Mar 13, 2014
  5. Junio C HamanoMar 13, 2014
  6. Junio C HamanoMar 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.