git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] fsck.c: Change the type of fsck_ident()'s first argument

From
Yuxuan Shui <yshuiv7@gmail.com>
Date
Mar 12, 2014, 18:18 UTC
Message-ID
<1394648304-19159-2-git-send-email-yshuiv7@gmail.com>
In-Reply-To
<1394648304-19159-1-git-send-email-yshuiv7@gmail.com>

Since fsck_ident doesn't change the content of **ident, the type of ident could be const char **.

This change is required to rewrite fsck_commit() to use skip_prefix().
---
 fsck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsck.c b/fsck.c
index 99c0497..1789c34 100644
--- a/fsck.c
+++ b/fsck.c
@@ -243,7 +243,7 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
 	return retval;
 }
 
-static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
+static int fsck_ident(const char **ident, struct object *obj, fsck_error error_func)
 {
 	if (**ident == '<')
 		return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email");
-- 
1.9.0
Previous: Yuxuan ShuiNext: Yuxuan Shui
Message 2 of 3 in “GSoC micro project, use skip_prefix() in fsck_commit()”
  1. 0/2 GSoC micro project, use skip_prefix() in fsck_commit()Yuxuan Shui, Mar 12, 2014
  2. 1/2 fsck.c: Change the type of fsck_ident()'s first argumentYuxuan Shui, Mar 12, 2014
  3. 2/2 fsck.c: Rewrite fsck_commit() to use skip_prefix()Yuxuan Shui, Mar 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.