git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 14/14] sha1_file.c: use ALLOC_GROW() in pretend_sha1_file()

From
DDDmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
Date
Mar 3, 2014, 22:32 UTC
Message-ID
<1393885922-21616-15-git-send-email-dmitrys.dolzhenko@yandex.ru>
In-Reply-To
<1393885922-21616-1-git-send-email-dmitrys.dolzhenko@yandex.ru>
Helped-by: He Sun <sunheehnus@gmail.com>
Signed-off-by: Dmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru>
---
 sha1_file.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 019628a..3cb17b8 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2624,12 +2624,7 @@ int pretend_sha1_file(void *buf, unsigned long len, enum object_type type,
 	hash_sha1_file(buf, len, typename(type), sha1);
 	if (has_sha1_file(sha1) || find_cached_object(sha1))
 		return 0;
-	if (cached_object_alloc <= cached_object_nr) {
-		cached_object_alloc = alloc_nr(cached_object_alloc);
-		cached_objects = xrealloc(cached_objects,
-					  sizeof(*cached_objects) *
-					  cached_object_alloc);
-	}
+	ALLOC_GROW(cached_objects, cached_object_nr + 1, cached_object_alloc);
 	co = &cached_objects[cached_object_nr++];
 	co->size = len;
 	co->type = type;
-- 
1.8.3.2
Previous: Dmitry S. DolzhenkoNext: Junio C Hamano
Message 16 of 17 in “Use ALLOC_GROW() instead of inline code”
  1. 00/14 Use ALLOC_GROW() instead of inline codeDmitry S. Dolzhenko, Mar 3, 2014
  2. 01/14 builtin/pack-objects.c: use ALLOC_GROW() in check_pbase_path()Dmitry S. Dolzhenko, Mar 3, 2014
  3. 02/14 bundle.c: use ALLOC_GROW() in add_to_ref_list()Dmitry S. Dolzhenko, Mar 3, 2014
  4. 03/14 cache-tree.c: use ALLOC_GROW() in find_subtree()Dmitry S. Dolzhenko, Mar 3, 2014
  5. 04/14 commit.c: use ALLOC_GROW() in register_commit_graft()Dmitry S. Dolzhenko, Mar 3, 2014
  6. 05/14 diff.c: use ALLOC_GROW()Dmitry S. Dolzhenko, Mar 3, 2014
  7. Junio C HamanoMar 3, 2014
  8. 06/14 diffcore-rename.c: use ALLOC_GROW()Dmitry S. Dolzhenko, Mar 3, 2014
  9. 07/14 patch-ids.c: use ALLOC_GROW() in add_commit()Dmitry S. Dolzhenko, Mar 3, 2014
  10. 08/14 replace_object.c: use ALLOC_GROW() in register_replace_object()Dmitry S. Dolzhenko, Mar 3, 2014
  11. 09/14 reflog-walk.c: use ALLOC_GROW()Dmitry S. Dolzhenko, Mar 3, 2014
  12. 10/14 dir.c: use ALLOC_GROW() in create_simplify()Dmitry S. Dolzhenko, Mar 3, 2014
  13. 11/14 attr.c: use ALLOC_GROW() in handle_attr_line()Dmitry S. Dolzhenko, Mar 3, 2014
  14. 12/14 builtin/mktree.c: use ALLOC_GROW() in append_to_tree()Dmitry S. Dolzhenko, Mar 3, 2014
  15. 13/14 read-cache.c: use ALLOC_GROW() in add_index_entry()Dmitry S. Dolzhenko, Mar 3, 2014
  16. 14/14 sha1_file.c: use ALLOC_GROW() in pretend_sha1_file()Dmitry S. Dolzhenko, Mar 3, 2014
  17. Junio C HamanoMar 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.