git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-compat-util.h:rewrite skip_prefix() as loop

From
Siddharth Goel <siddharth98391@gmail.com>
Date
Mar 1, 2014, 13:32 UTC
Message-ID
<1393680724-19983-1-git-send-email-siddharth98391@gmail.com>
Rewrote skip_prefix() function so that prefix is scanned once.
Signed-off-by: Siddharth Goel <siddharth98391@gmail.com>
---
 git-compat-util.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 614a5e9..550dce3 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -357,8 +357,11 @@ extern int suffixcmp(const char *str, const char *suffix);
 
 static inline const char *skip_prefix(const char *str, const char *prefix)
 {
-	size_t len = strlen(prefix);
-	return strncmp(str, prefix, len) ? NULL : str + len;
+	while (*prefix != '\0' && *str == *prefix) {
+		str++;
+		prefix++;
+	}
+	return (*prefix == '\0' ? str : NULL);
 }
 
 #if defined(NO_MMAP) || defined(USE_WIN32_MMAP)
-- 
1.9.0.138.g2de3478.dirty
Next: Siddharth Goel
Message 1 of 4 in “git-compat-util.h:rewrite skip_prefix() as loop”
  1. git-compat-util.h:rewrite skip_prefix() as loopSiddharth Goel, Mar 1, 2014
  2. Siddharth GoelMar 2, 2014
  3. Eric SunshineMar 2, 2014
  4. Eric SunshineMar 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.