git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] Performance improvement: don't drop origin blobs that are going to get tested next.

From
David Kastrup <dak@gnu.org>
Date
Feb 3, 2014, 19:14 UTC
Message-ID
<1391454849-26558-5-git-send-email-dak@gnu.org>
In-Reply-To
<1391454849-26558-1-git-send-email-dak@gnu.org>
---
 builtin/blame.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index e881b6e..0188115 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -1435,7 +1435,8 @@ static void pass_blame(struct scoreboard *sb, struct origin *origin, int opt)
  finish:
 	for (i = 0; i < num_sg; i++) {
 		if (sg_origin[i]) {
-			drop_origin_blob(sg_origin[i]);
+			if (!sg_origin[i]->suspects)
+				drop_origin_blob(sg_origin[i]);
 			origin_decref(sg_origin[i]);
 		}
 	}
-- 
1.8.3.2
Previous: David KastrupNext: David Kastrup
Message 5 of 6 in “git-blame: further performance preview”
  1. 0/5 git-blame: further performance previewDavid Kastrup, Feb 3, 2014
  2. 1/5 builtin/blame.c: struct blame_entry does not need a prev linkDavid Kastrup, Feb 3, 2014
  3. 2/5 Eliminate same_suspect function in builtin/blame.cDavid Kastrup, Feb 3, 2014
  4. 3/5 builtin/blame.c: large-scale rewriteDavid Kastrup, Feb 3, 2014
  5. 4/5 Performance improvement: don't drop origin blobs that are going to get tested next.David Kastrup, Feb 3, 2014
  6. 5/5 Avoid queuing commits multiple times for the same originDavid Kastrup, Feb 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.