git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/4] completion: introduce __gitcomp_nl_append ()

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jan 3, 2014, 19:57 UTC
Message-ID
<1388779022-14536-3-git-send-email-artagnon@gmail.com>
In-Reply-To
<1388779022-14536-1-git-send-email-artagnon@gmail.com>

There are situations where multiple classes of completions possible. For example

  branch.<TAB>
should try to complete
  branch.master.
  branch.autosetupmerge
  branch.autosetuprebase

The first candidate has the suffix ".", and the second/ third candidates have the suffix " ". To facilitate completions of this kind, create a variation of __gitcomp_nl () that appends to the existing list of completion candidates, COMPREPLY.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 contrib/completion/git-completion.bash | 13 +++++++++++++
 contrib/completion/git-completion.zsh  |  8 ++++++++
 2 files changed, 21 insertions(+)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 51c2dd4..bf358d6 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -233,6 +233,19 @@ __gitcomp_nl ()
 	__gitcompadd "$1" "${2-}" "${3-$cur}" "${4- }"
 }
 
+# Variation of __gitcomp_nl () that appends to the existing list of
+# completion candidates, COMPREPLY.
+__gitcomp_nl_append ()
+{
+	local IFS=$'\n'
+	local i=${#COMPREPLY[@]}
+	for x in $1; do
+		if [[ "$x" == "$3"* ]]; then
+			COMPREPLY[i++]="$2$x$4"
+		fi
+	done
+}
+
 # Generates completion reply with compgen from newline-separated possible
 # completion filenames.
 # It accepts 1 to 3 arguments:
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 6fca145..6b77968 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -76,6 +76,14 @@ __gitcomp_nl ()
 	compadd -Q -S "${4- }" -p "${2-}" -- ${=1} && _ret=0
 }
 
+__gitcomp_nl_append ()
+{
+	emulate -L zsh
+
+	local IFS=$'\n'
+	compadd -Q -S "${4- }" -p "${2-}" -- ${=1} && _ret=0
+}
+
 __gitcomp_file ()
 {
 	emulate -L zsh
-- 
1.8.5.2.227.g53f3478
Previous: Ramkumar RamachandraNext: Junio C Hamano
Message 3 of 8 in “Fix branch.autosetup(merge|rebase) completion”
  1. 0/4 Fix branch.autosetup(merge|rebase) completionRamkumar Ramachandra, Jan 3, 2014
  2. 1/4 completion: prioritize ./git-completion.bashRamkumar Ramachandra, Jan 3, 2014
  3. 2/4 completion: introduce __gitcomp_nl_append ()Ramkumar Ramachandra, Jan 3, 2014
  4. Junio C HamanoJan 3, 2014
  5. Ramkumar RamachandraJan 5, 2014
  6. 3/4 completion: fix branch.autosetup(merge|rebase)Ramkumar Ramachandra, Jan 3, 2014
  7. 4/4 completion: fix remote.pushdefaultRamkumar Ramachandra, Jan 3, 2014
  8. Junio C HamanoJan 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.