git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 2/6] transport-helper: don't update refs in dry-run

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Dec 7, 2013, 21:08 UTC
Message-ID
<1386450492-22348-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1386450492-22348-1-git-send-email-felipe.contreras@gmail.com>
The remote helper namespace should not be updated.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 transport-helper.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index b66c7fd..9558a0d 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -728,7 +728,8 @@ static int push_update_ref_status(struct strbuf *buf,
 }
 
 static void push_update_refs_status(struct helper_data *data,
-				    struct ref *remote_refs)
+				    struct ref *remote_refs,
+				    int flags)
 {
 	struct strbuf buf = STRBUF_INIT;
 	struct ref *ref = remote_refs;
@@ -742,7 +743,7 @@ static void push_update_refs_status(struct helper_data *data,
 		if (push_update_ref_status(&buf, &ref, remote_refs))
 			continue;
 
-		if (!data->refspecs || data->no_private_update)
+		if (flags & TRANSPORT_PUSH_DRY_RUN || !data->refspecs || data->no_private_update)
 			continue;
 
 		/* propagate back the update to the remote namespace */
@@ -833,7 +834,7 @@ static int push_refs_with_push(struct transport *transport,
 	sendline(data, &buf);
 	strbuf_release(&buf);
 
-	push_update_refs_status(data, remote_refs);
+	push_update_refs_status(data, remote_refs, flags);
 	return 0;
 }
 
@@ -887,7 +888,7 @@ static int push_refs_with_export(struct transport *transport,
 
 	if (finish_command(&exporter))
 		die("Error while running fast-export");
-	push_update_refs_status(data, remote_refs);
+	push_update_refs_status(data, remote_refs, flags);
 	return 0;
 }
 
-- 
1.8.5.1+fc1
Previous: Junio C HamanoNext: Felipe Contreras
Message 4 of 8 in “transport-helper: fixes”
  1. 0/6 transport-helper: fixesFelipe Contreras, Dec 7, 2013
  2. 1/6 transport-helper: mismerge fixFelipe Contreras, Dec 7, 2013
  3. Junio C HamanoDec 9, 2013
  4. 2/6 transport-helper: don't update refs in dry-runFelipe Contreras, Dec 7, 2013
  5. 3/6 transport-helper: add 'force' to 'export' helpersFelipe Contreras, Dec 7, 2013
  6. 4/6 transport-helper: check for 'forced update' messageFelipe Contreras, Dec 7, 2013
  7. 5/6 test-hg.sh: tests are now expected to passFelipe Contreras, Dec 7, 2013
  8. 6/6 remote-bzr: support the new 'force' optionFelipe Contreras, Dec 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.