git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Change sed i\ usage to something Solaris' sed can handle

From
Ben Walton <bdwalton@gmail.com>
Date
Nov 3, 2013, 13:08 UTC
Message-ID
<1383484109-30838-1-git-send-email-bdwalton@gmail.com>
In-Reply-To
<xmqqeh72blpt.fsf@gitster.dls.corp.google.com>

Solaris' sed was choking on the i\ commands used in t4015-diff-whitespace as it couldn't parse the program properly. Modify two uses of sed that worked in GNU sed but not Solaris' (/usr/bin or /usr/xpg4/bin) to an equivalent form that is handled properly by both.

Signed-off-by: Ben Walton <bdwalton@gmail.com>
---
This addresses Andreas' comment about the extraneous \<nl>.
Sorry, I misunderstood the original comment.
 t/t4015-diff-whitespace.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
index 3fb4b97..604a838 100755
--- a/t/t4015-diff-whitespace.sh
+++ b/t/t4015-diff-whitespace.sh
@@ -145,7 +145,7 @@ test_expect_success 'another test, with --ignore-space-at-eol' 'test_cmp expect
 test_expect_success 'ignore-blank-lines: only new lines' '
 	test_seq 5 >x &&
 	git update-index x &&
-	test_seq 5 | sed "/3/i \\
+	test_seq 5 | sed "/3/i\\
 " >x &&
 	git diff --ignore-blank-lines >out &&
 	>expect &&
@@ -155,7 +155,8 @@ test_expect_success 'ignore-blank-lines: only new lines' '
 test_expect_success 'ignore-blank-lines: only new lines with space' '
 	test_seq 5 >x &&
 	git update-index x &&
-	test_seq 5 | sed "/3/i \ " >x &&
+	test_seq 5 | sed "/3/i\\
+ " >x &&
 	git diff -w --ignore-blank-lines >out &&
 	>expect &&
 	test_cmp out expect
-- 
1.8.3.2
Previous: Junio C Hamano
Message 6 of 6 in “Change sed i\ usage to something Solaris' sed can handle”
  1. Change sed i\ usage to something Solaris' sed can handleBen Walton, Oct 27, 2013
  2. Andreas SchwabOct 28, 2013
  3. Ben WaltonOct 28, 2013
  4. Andreas SchwabOct 28, 2013
  5. Junio C HamanoOct 30, 2013
  6. Change sed i\ usage to something Solaris' sed can handleBen Walton, Nov 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.