[PATCH v4 2/2] version-gen: fix versions
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Oct 12, 2013, 07:07 UTC
- Message-ID
- <1381561628-20665-3-git-send-email-felipe.contreras@gmail.com>
- In-Reply-To
- <1381561628-20665-1-git-send-email-felipe.contreras@gmail.com>
Virtually all packaging guidelines would prefer 1.8.4~rc1, over 1.8.4.rc1 or 1.8.4-rc1, so it makes sense to use that instead.
In particular, the only packaging we provide, git.spec, generates a wrong version, because git-1.8.4 < git-1.8.4.rc1, changing to ~rc1 fixes the problem as it's considered newer.
The same happens in dpkg.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- GIT-VERSION-GEN | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index e96538d..c04c4de 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -28,7 +28,7 @@ then VN=$(cat version) || VN="$DEF_VER" elif test -d ${GIT_DIR:-.git} -o -f .git && describe then - VN=$(echo "$VN" | sed -e 's/-/./g') + VN=$(echo "$VN" | sed -e 's/-/~/g') else VN="$DEF_VER" fi
-- 1.8.4-fc