git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 10/10] transport-helper: don't update refs in dry-run

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 12, 2013, 07:05 UTC
Message-ID
<1381561533-20381-9-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1381561533-20381-1-git-send-email-felipe.contreras@gmail.com>
The remote helper namespace should not be updated.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 transport-helper.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index ddb3309..d94eaf4 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -715,7 +715,8 @@ static int push_update_ref_status(struct strbuf *buf,
 }
 
 static void push_update_refs_status(struct helper_data *data,
-				    struct ref *remote_refs)
+				    struct ref *remote_refs,
+				    int flags)
 {
 	struct strbuf buf = STRBUF_INIT;
 	struct ref *ref = remote_refs;
@@ -729,7 +730,7 @@ static void push_update_refs_status(struct helper_data *data,
 		if (push_update_ref_status(&buf, &ref, remote_refs))
 			continue;
 
-		if (!data->refspecs)
+		if (flags & TRANSPORT_PUSH_DRY_RUN || !data->refspecs)
 			continue;
 
 		/* propagate back the update to the remote namespace */
@@ -799,7 +800,7 @@ static int push_refs_with_push(struct transport *transport,
 	sendline(data, &buf);
 	strbuf_release(&buf);
 
-	push_update_refs_status(data, remote_refs);
+	push_update_refs_status(data, remote_refs, flags);
 	return 0;
 }
 
@@ -869,7 +870,7 @@ static int push_refs_with_export(struct transport *transport,
 
 	if (finish_command(&exporter))
 		die("Error while running fast-export");
-	push_update_refs_status(data, remote_refs);
+	push_update_refs_status(data, remote_refs, flags);
 	return 0;
 }
 
-- 
1.8.4-fc
Previous: Felipe ContrerasNext: Felipe Contreras
Message 13 of 16 in “transport-helper: updates”
  1. 00/10 transport-helper: updatesFelipe Contreras, Oct 12, 2013
  2. 03/10 transport-helper: check for 'forced update' messageFelipe Contreras, Oct 12, 2013
  3. 05/10 fast-export: add new --refspec optionFelipe Contreras, Oct 12, 2013
  4. Eric SunshineOct 14, 2013
  5. 06/10 transport-helper: add support for old:new refspecFelipe Contreras, Oct 12, 2013
  6. 02/10 transport-helper: fix extra linesFelipe Contreras, Oct 12, 2013
  7. 09/10 transport-helper: add support to delete branchesFelipe Contreras, Oct 12, 2013
  8. 11/10 fixup! transport-helper: add support to delete branchesRichard Hansen, Oct 27, 2013
  9. Felipe ContrerasOct 27, 2013
  10. Felipe ContrerasOct 27, 2013
  11. 01/10 transport-helper: add 'force' to 'export' helpersFelipe Contreras, Oct 12, 2013
  12. 08/10 fast-export: add support to delete refsFelipe Contreras, Oct 12, 2013
  13. 10/10 transport-helper: don't update refs in dry-runFelipe Contreras, Oct 12, 2013
  14. 07/10 fast-import: add support to delete refsFelipe Contreras, Oct 12, 2013
  15. 04/10 fast-export: improve argument parsingFelipe Contreras, Oct 12, 2013
  16. Richard HansenOct 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.