git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/5] remote-helpers: add exec-path links

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 12, 2013, 07:04 UTC
Message-ID
<1381561465-20147-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1381561465-20147-1-git-send-email-felipe.contreras@gmail.com>

This way we don't have to modify the PATH ourselves and it's easier to test without 'make'.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile
index 8799c77..2e14b65 100644
--- a/contrib/remote-helpers/Makefile
+++ b/contrib/remote-helpers/Makefile
@@ -1,15 +1,15 @@
 TESTS := $(wildcard test-*.t)
 SCRIPTS := $(wildcard git-remote-*.py)
+LINKS := $(addprefix ../../,$(patsubst %.py,%,$(SCRIPTS)))
 
 export T := $(addprefix $(CURDIR)/,$(TESTS))
 export MAKE := $(MAKE) -e
-export PATH := $(CURDIR):$(PATH)
 export TEST_LINT := test-lint-executable test-lint-shell-syntax
 export TEST_DIRECTORY := $(CURDIR)/../../t
 
 export SCRIPT_PYTHON := $(addprefix $(CURDIR)/,$(SCRIPTS))
 
-all: $(SCRIPTS)
+all: $(LINKS)
 	$(MAKE) -C ../.. build-python-script
 
 install:
@@ -17,10 +17,14 @@ install:
 
 clean:
 	$(MAKE) -C ../.. clean-python-script
+	$(RM) $(LINKS)
 
 test: all
 	$(MAKE) -C ../../t $@
 
+$(LINKS):
+	ln -sf contrib/remote-helpers/$(notdir $@) ../..
+
 $(TESTS): all
 	$(MAKE) -C ../../t $(CURDIR)/$@
 
-- 
1.8.4-fc
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 5 in “remote-helpers: test reorganization”
  1. 0/5 remote-helpers: test reorganizationFelipe Contreras, Oct 12, 2013
  2. 5/5 remote-helpers: add exec-path linksFelipe Contreras, Oct 12, 2013
  3. 4/5 remote-helpers: allow direct test executionFelipe Contreras, Oct 12, 2013
  4. 3/5 remote-helpers: rename testsFelipe Contreras, Oct 12, 2013
  5. 2/5 build: fix installation of scriptsFelipe Contreras, Oct 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.