git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] clone: do not segfault when specifying a nonexistent branch

From
Stefan Beller <stefanbeller@googlemail.com>
Date
Oct 4, 2013, 14:20 UTC
Message-ID
<1380896459-6451-1-git-send-email-stefanbeller@googlemail.com>
In-Reply-To
<524EC896.3050703@opensoftware.pl>
I think we should emit a warning additionally?
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
---
 builtin/clone.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 0aff974..b764ad0 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -688,7 +688,7 @@ static void write_refspec_config(const char* src_ref_prefix,
 
 	if (option_mirror || !option_bare) {
 		if (option_single_branch && !option_mirror) {
-			if (option_branch) {
+			if (option_branch && our_head_points_at) {
 				if (strstr(our_head_points_at->name, "refs/tags/"))
 					strbuf_addf(&value, "+%s:%s", our_head_points_at->name,
 						our_head_points_at->name);
-- 
1.8.4.1.469.gb38b9db
Previous: Robert MitwickiNext: Duy Nguyen
Message 2 of 9 in “Bug: Segmentation fault (core dumped)”
  1. Robert MitwickiOct 4, 2013
  2. clone: do not segfault when specifying a nonexistent branchStefan Beller, Oct 4, 2013
  3. Duy NguyenOct 4, 2013
  4. Stefan BellerOct 6, 2013
  5. Duy NguyenOct 7, 2013
  6. clone: do not segfault when specifying a nonexistent branchStefan Beller, Oct 8, 2013
  7. Ralf ThielowOct 9, 2013
  8. clone --branch: refuse to clone if upstream repo is emptyRalf Thielow, Oct 11, 2013
  9. Duy NguyenOct 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.