git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] doc: don't claim that cherry calls patch-id

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Sep 24, 2013, 22:33 UTC
Message-ID
<1380061947-2353-1-git-send-email-mst@redhat.com>

The id is already different for binary files. The hash used is an implementation detail, so let's just document how diffs are compared.

Cc: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes from v1:
	address comments by Jonathan
 Documentation/git-cherry.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/git-cherry.txt b/Documentation/git-cherry.txt
index f6c19c7..2d0daae 100644
--- a/Documentation/git-cherry.txt
+++ b/Documentation/git-cherry.txt
@@ -14,8 +14,7 @@ DESCRIPTION
 -----------
 The changeset (or "diff") of each commit between the fork-point and <head>
 is compared against each commit between the fork-point and <upstream>.
-The commits are compared with their 'patch id', obtained from
-the 'git patch-id' program.
+The diffs are compared after removing any whitespace and line numbers.
 
 Every commit that doesn't exist in the <upstream> branch
 has its id (sha1) reported, prefixed by a symbol.  The ones that have
-- 
MST
Message 1 of 1 in “doc: don't claim that cherry calls patch-id”
  1. doc: don't claim that cherry calls patch-idMichael S. Tsirkin, Sep 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.