git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] doc: don't claim that cherry-pick calls patch-id

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Sep 24, 2013, 22:05 UTC
Message-ID
<1380060333-2226-1-git-send-email-mst@redhat.com>

The id is already different for binary files. Let's document that they are similar, not identical.

Cc: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 Documentation/git-cherry.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-cherry.txt b/Documentation/git-cherry.txt
index f6c19c7..66ff52f 100644
--- a/Documentation/git-cherry.txt
+++ b/Documentation/git-cherry.txt
@@ -13,12 +13,13 @@ SYNOPSIS
 DESCRIPTION
 -----------
 The changeset (or "diff") of each commit between the fork-point and <head>
-is compared against each commit between the fork-point and <upstream>.
-The commits are compared with their 'patch id', obtained from
-the 'git patch-id' program.
+is compared against diff of each commit between the fork-point and <upstream>.
+The diffs are compared with their diff id (sha1) calculated after removing
+any whitespace and line numbers (similar but not necessarily identical
+to 'patch id', obtained from the 'git patch-id' program).
 
 Every commit that doesn't exist in the <upstream> branch
-has its id (sha1) reported, prefixed by a symbol.  The ones that have
+has its diff id (sha1) reported, prefixed by a symbol.  The ones that have
 equivalent change already
 in the <upstream> branch are prefixed with a minus (-) sign, and those
 that only exist in the <head> branch are prefixed with a plus (+) symbol:
-- 
MST
Next: Jonathan Nieder
Message 1 of 7 in “doc: don't claim that cherry-pick calls patch-id”
  1. doc: don't claim that cherry-pick calls patch-idMichael S. Tsirkin, Sep 24, 2013
  2. Jonathan NiederSep 24, 2013
  3. Michael S. TsirkinSep 24, 2013
  4. Jonathan NiederSep 24, 2013
  5. Michael S. TsirkinSep 24, 2013
  6. Jonathan NiederSep 24, 2013
  7. Michael S. TsirkinSep 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.