git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 17/17] t5303: adapt the tests to run with --packv4

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Sep 21, 2013, 13:58 UTC
Message-ID
<1379771883-10278-18-git-send-email-pclouds@gmail.com>
In-Reply-To
<1379771883-10278-1-git-send-email-pclouds@gmail.com>

"git show-index" does not work with .idx v3 which is the default for .pack v4. Force .idx back to v2. Disable tests about OBJ_OFS_DELTA on v4 because that is not supported.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 t/t5303-pack-corruption-resilience.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/t/t5303-pack-corruption-resilience.sh b/t/t5303-pack-corruption-resilience.sh
index 35926de..21fd54a 100755
--- a/t/t5303-pack-corruption-resilience.sh
+++ b/t/t5303-pack-corruption-resilience.sh
@@ -36,7 +36,7 @@ create_new_pack() {
     blob_2=`git hash-object -t blob -w file_2` &&
     blob_3=`git hash-object -t blob -w file_3` &&
     pack=`printf "$blob_1\n$blob_2\n$blob_3\n" |
-          git pack-objects $@ .git/objects/pack/pack` &&
+	  git pack-objects --index-version=2 $@ .git/objects/pack/pack` &&
     pack=".git/objects/pack/pack-${pack}" &&
     git verify-pack -v ${pack}.pack
 }
@@ -205,7 +205,7 @@ test_expect_success \
      git cat-file blob $blob_2 > /dev/null &&
      git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     'corruption #0 in delta base reference of first delta (OBJ_OFS_DELTA)' \
     'create_new_pack --delta-base-offset &&
      git prune-packed &&
@@ -214,7 +214,7 @@ test_expect_success \
      test_must_fail git cat-file blob $blob_2 > /dev/null &&
      test_must_fail git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     '... but having a loose copy allows for full recovery' \
     'mv ${pack}.idx tmp &&
      git hash-object -t blob -w file_2 &&
@@ -223,7 +223,7 @@ test_expect_success \
      git cat-file blob $blob_2 > /dev/null &&
      git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     '... and then a repack "clears" the corruption' \
     'do_repack --delta-base-offset &&
      git prune-packed &&
@@ -232,7 +232,7 @@ test_expect_success \
      git cat-file blob $blob_2 > /dev/null &&
      git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     'corruption #1 in delta base reference of first delta (OBJ_OFS_DELTA)' \
     'create_new_pack --delta-base-offset &&
      git prune-packed &&
@@ -241,7 +241,7 @@ test_expect_success \
      test_must_fail git cat-file blob $blob_2 > /dev/null &&
      test_must_fail git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     '... but having a loose copy allows for full recovery' \
     'mv ${pack}.idx tmp &&
      git hash-object -t blob -w file_2 &&
@@ -250,7 +250,7 @@ test_expect_success \
      git cat-file blob $blob_2 > /dev/null &&
      git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     '... and then a repack "clears" the corruption' \
     'do_repack --delta-base-offset &&
      git prune-packed &&
@@ -259,7 +259,7 @@ test_expect_success \
      git cat-file blob $blob_2 > /dev/null &&
      git cat-file blob $blob_3 > /dev/null'
 
-test_expect_success \
+test_expect_success !PACKV4 \
     '... and a redundant pack allows for full recovery too' \
     'do_corrupt_object $blob_2 2 < zero &&
      git cat-file blob $blob_1 > /dev/null &&
-- 
1.8.2.83.gc99314b
Previous: Nguyễn Thái Ngọc DuyNext: Nicolas Pitre
Message 23 of 25 in “np/pack-v4 updates”
  1. 00/17 np/pack-v4 updatesNguyễn Thái Ngọc Duy, Sep 21, 2013
  2. 01/17 fixup! index-pack: record all delta bases in v4 (tree and ref-delta)Nguyễn Thái Ngọc Duy, Sep 21, 2013
  3. 02/17 fixup! packv4-parse.c: add tree offset cachingNguyễn Thái Ngọc Duy, Sep 21, 2013
  4. 03/17 fixup! pack-objects: support writing pack v4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  5. 04/17 fixup! pack-objects: recognize v4 as pack sourceNguyễn Thái Ngọc Duy, Sep 21, 2013
  6. 05/17 fixup! index-pack: support completing thin packs v4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  7. 06/17 fixup! pack v4: move packv4-create.c to libgit.aNguyễn Thái Ngọc Duy, Sep 21, 2013
  8. 07/17 fixup! index-pack, pack-objects: allow creating .idx v2 with .pack v4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  9. Nicolas PitreSep 22, 2013
  10. 08/17 fixup! pack v4: code to obtain a SHA1 from a sha1refNguyễn Thái Ngọc Duy, Sep 21, 2013
  11. 09/17 fixup! pack-objects: add --version to specify written pack versionNguyễn Thái Ngọc Duy, Sep 21, 2013
  12. 10/17 test-lib.sh: add --packv4 for running the tests with pack v4 as defaultNguyễn Thái Ngọc Duy, Sep 21, 2013
  13. 11/17 packv4-parse: accept ref-delta as base of pv4-treeNguyễn Thái Ngọc Duy, Sep 21, 2013
  14. 12/17 pack-objects: do not add type OBJ_NONE to objects[] in pack v4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  15. 13/17 index-pack: encode appended trees using v4 format in pack v4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  16. 14/17 t5302: disable sealth corruption tests when run with --packv4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  17. Eric SunshineSep 22, 2013
  18. 15/17 t5300: avoid testing ofs-delta with --packv4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  19. Nicolas PitreSep 21, 2013
  20. Duy NguyenSep 22, 2013
  21. Nicolas PitreSep 22, 2013
  22. 16/17 pack-objects: disable pack size limit feature on pack v4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  23. 17/17 t5303: adapt the tests to run with --packv4Nguyễn Thái Ngọc Duy, Sep 21, 2013
  24. Nicolas PitreSep 21, 2013
  25. Junio C HamanoOct 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.