git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] stop storing trailing slash in dir-hash

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Sep 13, 2013, 11:15 UTC
Message-ID
<1379070943-36595-1-git-send-email-sunshine@sunshineco.com>

This series alters name-hash so that it no longer stores the (redundant) trailing slash with index_state.dir_hash entries. As an intentional side-effect, the series fixes [1] in a cleaner way (suggested by Junio [2]) than either [3] (680be044 in master) or [4].

As noted by Peff [5], this change is at a fairly fundamental level, so care has been taken to ensure that all tests still pass (thus it at least does not break anything covered by the tests).

[1]: http://thread.gmane.org/gmane.comp.version-control.git/232727 [2]: http://thread.gmane.org/gmane.comp.version-control.git/232727/focus=232813 [3]: http://thread.gmane.org/gmane.comp.version-control.git/232796 [4]: http://thread.gmane.org/gmane.comp.version-control.git/232833 [5]: http://thread.gmane.org/gmane.comp.version-control.git/232727/focus=232822

Eric Sunshine (3):
  name-hash: refactor polymorphic index_name_exists()
  name-hash: stop storing trailing '/' on paths in index_state.dir_hash
  dir: revert work-around for retired dangerous behavior
 cache.h      |  2 ++
 dir.c        | 25 +++++++------------------
 name-hash.c  | 54 ++++++++++++++++++++++++++++--------------------------
 read-cache.c |  2 +-
 4 files changed, 38 insertions(+), 45 deletions(-)
-- 
1.8.4.457.g424cb08
Next: Eric Sunshine
Message 1 of 9 in “stop storing trailing slash in dir-hash”
  1. 0/3 stop storing trailing slash in dir-hashEric Sunshine, Sep 13, 2013
  2. 1/3 name-hash: refactor polymorphic index_name_exists()Eric Sunshine, Sep 13, 2013
  3. Junio C HamanoSep 13, 2013
  4. Eric SunshineSep 13, 2013
  5. 2/3 name-hash: stop storing trailing '/' on paths in index_state.dir_hashEric Sunshine, Sep 13, 2013
  6. 3/3 dir: revert work-around for retired dangerous behaviorEric Sunshine, Sep 13, 2013
  7. Eric SunshineSep 13, 2013
  8. Junio C HamanoSep 13, 2013
  9. Eric SunshineSep 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.