git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 2/5] t3200: Minor fix when preparing for tracking failure

From
Johan Herland <johan@herland.net>
Date
Sep 8, 2013, 20:58 UTC
Message-ID
<1378673895-23127-3-git-send-email-johan@herland.net>
In-Reply-To
<1378673895-23127-1-git-send-email-johan@herland.net>

We're testing that trying to --track a ref that is not covered by any remote refspec should fail. For that, we want to have refs/remotes/local/master present, but we also want the remote.local.fetch refspec to NOT match refs/remotes/local/master (so that the tracking setup will fail, as intended). However, when doing "git fetch local" to ensure the existence of refs/remotes/local/master, we must not already have changed remote.local.fetch so as to cause refs/remotes/local/master not to be fetched. Therefore, set remote.local.fetch to refs/heads/*:refs/remotes/local/* BEFORE we fetch, and then reset it to refs/heads/s:refs/remotes/local/s AFTER we have fetched (but before we test --track).

Signed-off-by: Johan Herland <johan@herland.net>
---
 t/t3200-branch.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index 44ec6a4..8f6ab8e 100755
--- a/t/t3200-branch.sh
+++ b/t/t3200-branch.sh
@@ -319,8 +319,9 @@ test_expect_success 'test tracking setup (non-wildcard, matching)' '
 
 test_expect_success 'tracking setup fails on non-matching refspec' '
 	git config remote.local.url . &&
-	git config remote.local.fetch refs/heads/s:refs/remotes/local/s &&
+	git config remote.local.fetch refs/heads/*:refs/remotes/local/* &&
 	(git show-ref -q refs/remotes/local/master || git fetch local) &&
+	git config remote.local.fetch refs/heads/s:refs/remotes/local/s &&
 	test_must_fail git branch --track my5 local/master &&
 	test_must_fail git config branch.my5.remote &&
 	test_must_fail git config branch.my5.merge
-- 
1.8.3.GIT
Previous: Johan HerlandNext: Johan Herland
Message 12 of 15 in “branch: Fix --track on a remote-tracking non-branch”
  1. 0/5 branch: Fix --track on a remote-tracking non-branchJohan Herland, Sep 6, 2013
  2. 1/5 t2024: Fix inconsequential typosJohan Herland, Sep 6, 2013
  3. Junio C HamanoSep 6, 2013
  4. Johan HerlandSep 6, 2013
  5. 2/5 t3200: Minor fix when preparing for tracking failureJohan Herland, Sep 6, 2013
  6. 3/5 Refer to branch.<name>.remote/merge when documenting --trackJohan Herland, Sep 6, 2013
  7. 4/5 t3200: Add test demonstrating minor regression in 41c21f2Johan Herland, Sep 6, 2013
  8. 5/5 branch.c: Relax unnecessary requirement on upstream's remote ref nameJohan Herland, Sep 6, 2013
  9. Junio C HamanoSep 6, 2013
  10. 0/5 branch: Fix --track on a remote-tracking non-branchJohan Herland, Sep 8, 2013
  11. 1/5 t2024: Fix &&-chaining and a couple of typosJohan Herland, Sep 8, 2013
  12. 2/5 t3200: Minor fix when preparing for tracking failureJohan Herland, Sep 8, 2013
  13. 3/5 Refer to branch.<name>.remote/merge when documenting --trackJohan Herland, Sep 8, 2013
  14. 4/5 t3200: Add test demonstrating minor regression in 41c21f2Johan Herland, Sep 8, 2013
  15. 5/5 branch.c: Relax unnecessary requirement on upstream's remote ref nameJohan Herland, Sep 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.