[PATCH] send-email: don't call methods on undefined values
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Sep 8, 2013, 20:54 UTC
- Message-ID
- <1378673674-97212-1-git-send-email-sandals@crustytoothpaste.net>
If SSL verification is enabled in git send-email, we could attempt to call a method on an undefined value if the verification failed, since $smtp would end up being undef. Look up the error string in a way that will produce a helpful error message and not cause further errors.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> --- git-send-email.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-send-email.perl b/git-send-email.perl index 2162478..3782c3b 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1234,7 +1234,7 @@ X-Mailer: git-send-email $gitversion if ($smtp->code == 220) { $smtp = Net::SMTP::SSL->start_SSL($smtp, ssl_verify_params()) - or die "STARTTLS failed! ".$smtp->message; + or die "STARTTLS failed! ".IO::Socket::SSL::errstr(); $smtp_encryption = ''; # Send EHLO again to receive fresh # supported commands
-- 1.8.4.rc3