git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] git-remote-mediawiki: add test and check Makefile targets

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Aug 21, 2013, 08:10 UTC
Message-ID
<1377072617-25086-2-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<1377072617-25086-1-git-send-email-Matthieu.Moy@imag.fr>

There are a few level 4 and 2 perlcritic issues in the current code. We make level 5 fatal, and keep level 2 as warnings so that "make check" pass.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 contrib/mw-to-git/Makefile | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/Makefile b/contrib/mw-to-git/Makefile
index 76fcd4d..f206f96 100644
--- a/contrib/mw-to-git/Makefile
+++ b/contrib/mw-to-git/Makefile
@@ -24,6 +24,11 @@ INSTLIBDIR=$(shell $(MAKE) -C $(GIT_ROOT_DIR)/perl \
 
 all: build
 
+test: all
+	$(MAKE) -C t
+
+check: perlcritic test
+
 install_pm:
 	install $(GIT_MEDIAWIKI_PM) $(INSTLIBDIR)/$(GIT_MEDIAWIKI_PM)
 
@@ -41,4 +46,7 @@ clean:
 	rm $(INSTLIBDIR)/$(GIT_MEDIAWIKI_PM)
 
 perlcritic:
-	perlcritic -2 *.perl
+	perlcritic -5 $(SCRIPT_PERL)
+	-perlcritic -2 $(SCRIPT_PERL)
+
+.PHONY: all test check install_pm install clean perlcritic
-- 
1.8.4.rc2.18.g030d947
Previous: Matthieu MoyNext: Junio C Hamano
Message 2 of 4 in “git-remote-mediawiki: reset private ref after non-dumb push”
  1. 1/2 git-remote-mediawiki: reset private ref after non-dumb pushMatthieu Moy, Aug 21, 2013
  2. 2/2 git-remote-mediawiki: add test and check Makefile targetsMatthieu Moy, Aug 21, 2013
  3. Junio C HamanoAug 21, 2013
  4. Matthieu MoyAug 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.