[PATCH 1/3] dir.c: use the cache_* macro to access the current index
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 15, 2013, 21:28 UTC
- Message-ID
- <1376602090-19142-2-git-send-email-gitster@pobox.com>
- In-Reply-To
- <1376602090-19142-1-git-send-email-gitster@pobox.com>
These codepaths always start from the_index and use index_* functions, but there is no reason to do so. Use the compatibility cache_* macro to access the current in-core index like everybody else.
While at it, fix typo in the comment for a function to check if a path within a directory appears in the index.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- dir.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/dir.c b/dir.c index a5926fb..2f82cd1 100644 --- a/dir.c +++ b/dir.c @@ -472,15 +472,14 @@ static void *read_skip_worktree_file_from_index(const char *path, size_t *size) unsigned long sz; enum object_type type; void *data; - struct index_state *istate = &the_index; len = strlen(path); - pos = index_name_pos(istate, path, len); + pos = cache_name_pos(path, len); if (pos < 0) return NULL; - if (!ce_skip_worktree(istate->cache[pos])) + if (!ce_skip_worktree(active_cache[pos])) return NULL; - data = read_sha1_file(istate->cache[pos]->sha1, &type, &sz); + data = read_sha1_file(active_cache[pos]->sha1, &type, &sz); if (!data || type != OBJ_BLOB) { free(data); return NULL; @@ -924,13 +923,13 @@ enum exist_status { }; /* - * Do not use the alphabetically stored index to look up + * Do not use the alphabetically sorted index to look up * the directory name; instead, use the case insensitive * name hash. */ static enum exist_status directory_exists_in_index_icase(const char *dirname, int len) { - struct cache_entry *ce = index_name_exists(&the_index, dirname, len + 1, ignore_case); + struct cache_entry *ce = cache_name_exists(dirname, len + 1, ignore_case); unsigned char endchar; if (!ce)
-- 1.8.4-rc3-232-ga8053f8