git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] fix interactive rebase short SHA-1 collision bug

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 12, 2013, 04:07 UTC
Message-ID
<1376280459-55188-1-git-send-email-sunshine@sunshineco.com>

This series addresses a bug [1][2] which can manifest during interactive rebase when the prefix of the new SHA-1 of an edited commit is shared with the abbreviated SHA-1 of a subsequent commit in the 'todo' list. When rebase attempts to process the subsequent command, it dies with a "short SHA1 badbeef is ambiguous" error.

patch 1: fix a problem in the interactive rebase test suite which can
    make subsequent tests fail
patch 2: add a test demonstrating the short SHA-1 collision bug
patch 3: fix the bug (this patch is from Junio [3] but augmented also to
    fix up "rebase --edit-todo")

[1]: http://thread.gmane.org/gmane.comp.version-control.git/229091 [2]: http://thread.gmane.org/gmane.comp.version-control.git/232012 [3]: http://thread.gmane.org/gmane.comp.version-control.git/229091/focus=229120

Eric Sunshine (2):
  t3404: restore specialized rebase-editor following commentchar test
  t3404: rebase: interactive: demonstrate short SHA-1 collision
Junio C Hamano (1):
  rebase: interactive: fix short SHA-1 collision
 git-rebase--interactive.sh    | 30 ++++++++++++++++++++++++++++++
 t/t3404-rebase-interactive.sh | 18 ++++++++++++++++++
 2 files changed, 48 insertions(+)
-- 
1.8.4.rc2.460.ga591f4a
Next: Eric Sunshine
Message 1 of 8 in “fix interactive rebase short SHA-1 collision bug”
  1. 0/3 fix interactive rebase short SHA-1 collision bugEric Sunshine, Aug 12, 2013
  2. 1/3 t3404: restore specialized rebase-editor following commentchar testEric Sunshine, Aug 12, 2013
  3. Junio C HamanoAug 12, 2013
  4. Eric SunshineAug 12, 2013
  5. 2/3 t3404: rebase: interactive: demonstrate short SHA-1 collisionEric Sunshine, Aug 12, 2013
  6. Junio C HamanoAug 12, 2013
  7. Eric SunshineAug 12, 2013
  8. 3/3 rebase: interactive: fix short SHA-1 collisionEric Sunshine, Aug 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.