git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git p4 test: sanitize P4CHARSET

From
PWPete Wyckoff <pw@padd.com>
Date
Aug 10, 2013, 20:15 UTC
Message-ID
<1376165713-26170-1-git-send-email-pw@padd.com>
In-Reply-To
<20130810201123.GA31706@padd.com>
From: kazuki saitoh <ksaitoh560@gmail.com>

In the tests, p4d is started without using "internationalized mode". Make sure this environment variable is unset, otherwise a mis-matched user setting would break the tests. The error message would be "Unicode clients require a unicode enabled server."

[pw: use unset, add commit text]
Signed-off-by: Kazuki Saitoh <ksaitoh560@gmail.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 t/lib-git-p4.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 2098b9b..ccd918e 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh
@@ -48,7 +48,8 @@ P4DPORT=$((10669 + ($testid - $git_p4_test_start)))
 P4PORT=localhost:$P4DPORT
 P4CLIENT=client
 P4EDITOR=:
-export P4PORT P4CLIENT P4EDITOR
+unset P4CHARSET
+export P4PORT P4CLIENT P4EDITOR P4CHARSET
 
 db="$TRASH_DIRECTORY/db"
 cli="$TRASH_DIRECTORY/cli"
-- 
1.8.4.rc2.88.ga5463da
Previous: Pete WyckoffNext: Pete Wyckoff
Message 3 of 9 in “git-p4: Ask "p4" to interpret View setting”
  1. git-p4: Ask "p4" to interpret View settingkazuki saitoh, Aug 6, 2013
  2. Pete WyckoffAug 10, 2013
  3. 1/2 git p4 test: sanitize P4CHARSETPete Wyckoff, Aug 10, 2013
  4. 2/2 git p4: implement view spec wildcards with "p4 where"Pete Wyckoff, Aug 10, 2013
  5. kazuki saitohAug 14, 2013
  6. Pete WyckoffAug 16, 2013
  7. Pete WyckoffAug 25, 2013
  8. kazuki saitohAug 27, 2013
  9. Pete WyckoffAug 29, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.