[PATCH 1/4] OPT__QUIET(): switch from count-up to true bool

The parseopt parsing for OPT__QUIET() is implemented in terms of OPT_BOOLEAN aka OPT_COUNTUP, so a user _could_ theoretically have used it to make "git cmd -q -q" and "git cmd -q" behave differently.

However, no existing user does so (a summary of the audit at the end). Use OPT_BOOL to make sure our choices are either 0 or 1.

    builtin/branch.c:

	quiet is passed to create_branch() in branch.c and
	delete_branches().  The former passes it to setup_tracking()
	which is used as a bool to decide use of BRANCH_CONFIG_VERBOSE.
	The latter uses it as a bool to give a single printf() for
	reporting the names of deleted branches.

    builtin/check-ignore.c:

	all users of quiet use it as a bool.

    builtin/checkout-index.c:

	quiet is assigned to state.quite and only the latter is used
	throughout the program.  It is a single-bit bitfield.

    builtin/checkout.c:

	quiet is stored in checkout_opts.quiet which is of type int.  It
	is used in many places:

	- reset_tree() uses it as a bool;

	- merge_working_tree() uses it twice, as a bool at both
	  places;

	- update_refs_for_switch() uses it three times, all as a bool.
	  It also passes it to create_branch() which we already verified
	  above.

	- switch_branches() and switch_unborn_to_new_branch() use it
	  once each, as a bool at both places.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 parse-options.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)