git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] [SIGNED-OFF] remotes-hg: bugfix for fetching non local remotes

From
Joern Hees <dev@joernhees.de>
Date
Jul 23, 2013, 21:40 UTC
Message-ID
<1374615616-4730-1-git-send-email-dev@joernhees.de>

6796d49 introduced a bug by making shared_path == ".git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: "mercurial.error.RepoError: repository .git/hg not found"

Changing gitdir to dirname causes shared_path == .git/hg/<remote_name>/hg. The call to hg.share with local_path == .git/hg/<remote_name>/clone works again.

Signed-off-by: Joern Hees <dev@joernhees.de>
---
 contrib/remote-helpers/git-remote-hg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 0194c67..89dd4cc 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -390,7 +390,7 @@ def get_repo(url, alias):
         if not os.path.exists(dirname):
             os.makedirs(dirname)
     else:
-        shared_path = os.path.join(gitdir, 'hg')
+        shared_path = os.path.join(dirname, 'hg')
         if not os.path.exists(shared_path):
             try:
                 hg.clone(myui, {}, url, shared_path, update=False, pull=True)
-- 
1.8.3.3
Next: Antoine Pelisse
Message 1 of 9 in “[SIGNED-OFF] remotes-hg: bugfix for fetching non local remotes”
  1. [SIGNED-OFF] remotes-hg: bugfix for fetching non local remotesJoern Hees, Jul 23, 2013
  2. Antoine PelisseJul 24, 2013
  3. Jörn HeesJul 24, 2013
  4. Antoine PelisseJul 24, 2013
  5. Jörn HeesJul 24, 2013
  6. Junio C HamanoJul 24, 2013
  7. Jörn HeesJul 24, 2013
  8. Junio C HamanoJul 24, 2013
  9. Felipe ContrerasJul 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.