git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Finishing touches to "name-rev" fix

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 18, 2013, 22:16 UTC
Message-ID
<1374185768-7537-1-git-send-email-gitster@pobox.com>

This is an update to finish the jc/name-rev-exact-ref topic, which fixed the command to convert an object name that points at a tag to a refname of the tag (earlier, it did not show anything). The codepath to handle its command line arguments, however, fed the commit that the tag points at to the underlying naming machinery.

The first patch in this follow-up series corrects it for the command line codepath.

The second patch is a related fix for "git describe". The command is about naming the given commit in relation to a tag in its neighbourhood, and while it does allow the input to be a commit-ish (e.g. a tag that points at a commit), it did not unwrap it down to commit, which is a bug (it is like "git commit-tree -p $tag" that would mistakenly record a tag object as one of the parents of the resulting commit).

Junio C Hamano (2):
  name-rev: differentiate between tags and commits they point at
  describe: fix --contains when a tag is given as input
 builtin/describe.c  |  3 ++-
 builtin/name-rev.c  | 41 ++++++++++++++++++++++++++++++++---------
 t/t6120-describe.sh | 24 ++++++++++++++++++++++++
 3 files changed, 58 insertions(+), 10 deletions(-)
-- 
1.8.3.3-992-gf0e5e44
Next: Junio C Hamano
Message 1 of 3 in “Finishing touches to "name-rev" fix”
  1. 0/2 Finishing touches to "name-rev" fixJunio C Hamano, Jul 18, 2013
  2. 1/2 name-rev: differentiate between tags and commits they point atJunio C Hamano, Jul 18, 2013
  3. 2/2 describe: fix --contains when a tag is given as inputJunio C Hamano, Jul 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.