[PATCH 2/3] http-push.c, add_send_request: Do not initialize transfer_request.
- From
Stefan Beller <stefanbeller@googlemail.com>
- Date
- Jul 18, 2013, 21:35 UTC
- Message-ID
- <1374183327-14939-2-git-send-email-stefanbeller@googlemail.com>
- In-Reply-To
- <1374183327-14939-1-git-send-email-stefanbeller@googlemail.com>
That pointer will be assigned to new memory via request = xmalloc(sizeof(*request)); 20 lines later unconditionally anyway, so it's safe to not assign it to an arbitrary variable.
As this patch is a micro-optimization (for readability?) it would be nice to have as little work with this patch, so maybe I need a feature to send a patch without a symmetric number of lines around change-diff. For this patch I'd be only interested in showing the next 20 lines, but nothing really before the function declaration.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com> --- http-push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http-push.c b/http-push.c index 395a8cf..6dad188 100644 --- a/http-push.c +++ b/http-push.c @@ -663,7 +663,7 @@ static void add_fetch_request(struct object *obj) static int add_send_request(struct object *obj, struct remote_lock *lock) { - struct transfer_request *request = request_queue_head; + struct transfer_request *request; struct packed_git *target; /* Keep locks active */
-- 1.8.3.3.754.g9c3c367.dirty