git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 40/46] parse_pathspec: make sure the prefix part is wildcard-free

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jul 14, 2013, 08:36 UTC
Message-ID
<1373790969-13000-41-git-send-email-pclouds@gmail.com>
In-Reply-To
<1373790969-13000-1-git-send-email-pclouds@gmail.com>

Prepending prefix to pathspec is a trick to workaround the fact that commands can be executed in a subdirectory, but all git commands run at worktree's root. The prefix part should always be treated as literal string. Make it so.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 cache.h    |  2 ++
 path.c     | 15 ++++++++++++++-
 pathspec.c | 21 +++++++++++++++++----
 pathspec.h |  2 +-
 setup.c    | 24 ++++++++++++++++++++----
 5 files changed, 54 insertions(+), 10 deletions(-)
diff --git a/cache.h b/cache.h
index b0ed117..13e3c94 100644
--- a/cache.h
+++ b/cache.h
@@ -414,6 +414,7 @@ extern void setup_work_tree(void);
 extern const char *setup_git_directory_gently(int *);
 extern const char *setup_git_directory(void);
 extern char *prefix_path(const char *prefix, int len, const char *path);
+extern char *prefix_path_gently(const char *prefix, int len, int *remaining, const char *path);
 extern const char *prefix_filename(const char *prefix, int len, const char *path);
 extern int check_filename(const char *prefix, const char *name);
 extern void verify_filename(const char *prefix,
@@ -741,6 +742,7 @@ const char *real_path(const char *path);
 const char *real_path_if_valid(const char *path);
 const char *absolute_path(const char *path);
 const char *relative_path(const char *abs, const char *base);
+int normalize_path_copy_len(char *dst, const char *src, int *prefix_len);
 int normalize_path_copy(char *dst, const char *src);
 int longest_ancestor_length(const char *path, struct string_list *prefixes);
 char *strip_path_suffix(const char *path, const char *suffix);
diff --git a/path.c b/path.c
index 04ff148..f4b49d6 100644
--- a/path.c
+++ b/path.c
@@ -492,8 +492,14 @@ const char *relative_path(const char *abs, const char *base)
  *
  * Note that this function is purely textual.  It does not follow symlinks,
  * verify the existence of the path, or make any system calls.
+ *
+ * prefix_len != NULL is for a specific case of prefix_pathspec():
+ * assume that src == dst and src[0..prefix_len-1] is already
+ * normalized, any time "../" eats up to the prefix_len part,
+ * prefix_len is reduced. In the end prefix_len is the remaining
+ * prefix that has not been overridden by user pathspec.
  */
-int normalize_path_copy(char *dst, const char *src)
+int normalize_path_copy_len(char *dst, const char *src, int *prefix_len)
 {
 	char *dst0;
 
@@ -568,11 +574,18 @@ int normalize_path_copy(char *dst, const char *src)
 		/* Windows: dst[-1] cannot be backslash anymore */
 		while (dst0 < dst && dst[-1] != '/')
 			dst--;
+		if (prefix_len && *prefix_len > dst - dst0)
+			*prefix_len = dst - dst0;
 	}
 	*dst = '\0';
 	return 0;
 }
 
+int normalize_path_copy(char *dst, const char *src)
+{
+	return normalize_path_copy_len(dst, src, NULL);
+}
+
 /*
  * path = Canonical absolute path
  * prefixes = string_list containing normalized, absolute paths without
diff --git a/pathspec.c b/pathspec.c
index da802e2..71e5eaf 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -150,10 +150,14 @@ static unsigned prefix_pathspec(struct pathspec_item *item,
 	magic |= short_magic;
 	*p_short_magic = short_magic;
 
-	if (magic & PATHSPEC_FROMTOP)
+	if (magic & PATHSPEC_FROMTOP) {
 		match = xstrdup(copyfrom);
-	else
-		match = prefix_path(prefix, prefixlen, copyfrom);
+		prefixlen = 0;
+	} else {
+		match = prefix_path_gently(prefix, prefixlen, &prefixlen, copyfrom);
+		if (!match)
+			die(_("%s: '%s' is outside repository"), elt, copyfrom);
+	}
 	*raw = item->match = match;
 	/*
 	 * Prefix the pathspec (keep all magic) and assign to
@@ -167,6 +171,7 @@ static unsigned prefix_pathspec(struct pathspec_item *item,
 	} else
 		item->original = elt;
 	item->len = strlen(item->match);
+	item->prefix = prefixlen;
 
 	if ((flags & PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP) &&
 	    (item->len >= 1 && item->match[item->len - 1] == '/') &&
@@ -198,13 +203,20 @@ static unsigned prefix_pathspec(struct pathspec_item *item,
 
 	if (limit_pathspec_to_literal())
 		item->nowildcard_len = item->len;
-	else
+	else {
 		item->nowildcard_len = simple_length(item->match);
+		if (item->nowildcard_len < prefixlen)
+			item->nowildcard_len = prefixlen;
+	}
 	item->flags = 0;
 	if (item->nowildcard_len < item->len &&
 	    item->match[item->nowildcard_len] == '*' &&
 	    no_wildcard(item->match + item->nowildcard_len + 1))
 		item->flags |= PATHSPEC_ONESTAR;
+
+	/* sanity checks, pathspec matchers assume these are sane */
+	assert(item->nowildcard_len <= item->len &&
+	       item->prefix         <= item->len);
 	return magic;
 }
 
@@ -284,6 +296,7 @@ void parse_pathspec(struct pathspec *pathspec,
 		item->match = prefix;
 		item->original = prefix;
 		item->nowildcard_len = item->len = strlen(prefix);
+		item->prefix = item->len;
 		raw[0] = prefix;
 		raw[1] = NULL;
 		pathspec->nr = 1;
diff --git a/pathspec.h b/pathspec.h
index 0f6739d..2f3532e 100644
--- a/pathspec.h
+++ b/pathspec.h
@@ -21,7 +21,7 @@ struct pathspec {
 		const char *match;
 		const char *original;
 		unsigned magic;
-		int len;
+		int len, prefix;
 		int nowildcard_len;
 		int flags;
 	} *items;
diff --git a/setup.c b/setup.c
index d1ece5d..ff4499e 100644
--- a/setup.c
+++ b/setup.c
@@ -5,7 +5,19 @@
 static int inside_git_dir = -1;
 static int inside_work_tree = -1;
 
-static char *prefix_path_gently(const char *prefix, int len, const char *path)
+/*
+ * Normalize "path", prepending the "prefix" for relative paths. If
+ * remaining_prefix is not NULL, return the actual prefix still
+ * remains in the path. For example, prefix = sub1/sub2/ and path is
+ *
+ *  foo          -> sub1/sub2/foo  (full prefix)
+ *  ../foo       -> sub1/foo       (remaining prefix is sub1/)
+ *  ../../bar    -> bar            (no remaining prefix)
+ *  ../../sub1/sub2/foo -> sub1/sub2/foo (but no remaining prefix)
+ *  `pwd`/../bar -> sub1/bar       (no remaining prefix)
+ */
+char *prefix_path_gently(const char *prefix, int len,
+			 int *remaining_prefix, const char *path)
 {
 	const char *orig = path;
 	char *sanitized;
@@ -13,13 +25,17 @@ static char *prefix_path_gently(const char *prefix, int len, const char *path)
 		const char *temp = real_path(path);
 		sanitized = xmalloc(len + strlen(temp) + 1);
 		strcpy(sanitized, temp);
+		if (remaining_prefix)
+			*remaining_prefix = 0;
 	} else {
 		sanitized = xmalloc(len + strlen(path) + 1);
 		if (len)
 			memcpy(sanitized, prefix, len);
 		strcpy(sanitized + len, path);
+		if (remaining_prefix)
+			*remaining_prefix = len;
 	}
-	if (normalize_path_copy(sanitized, sanitized))
+	if (normalize_path_copy_len(sanitized, sanitized, remaining_prefix))
 		goto error_out;
 	if (is_absolute_path(orig)) {
 		size_t root_len, len, total;
@@ -44,7 +60,7 @@ static char *prefix_path_gently(const char *prefix, int len, const char *path)
 
 char *prefix_path(const char *prefix, int len, const char *path)
 {
-	char *r = prefix_path_gently(prefix, len, path);
+	char *r = prefix_path_gently(prefix, len, NULL, path);
 	if (!r)
 		die("'%s' is outside repository", path);
 	return r;
@@ -53,7 +69,7 @@ char *prefix_path(const char *prefix, int len, const char *path)
 int path_inside_repo(const char *prefix, const char *path)
 {
 	int len = prefix ? strlen(prefix) : 0;
-	char *r = prefix_path_gently(prefix, len, path);
+	char *r = prefix_path_gently(prefix, len, NULL, path);
 	if (r) {
 		free(r);
 		return 1;

-- 
1.8.2.83.gc99314b
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 41 of 52 in “"struct pathspec" conversion and :(glob) and :(icase)”
  1. 00/46 "struct pathspec" conversion and :(glob) and :(icase)Nguyễn Thái Ngọc Duy, Jul 14, 2013
  2. 01/46 clean: remove unused variable "seen"Nguyễn Thái Ngọc Duy, Jul 14, 2013
  3. 02/46 Move struct pathspec and related functions to pathspec.[ch]Nguyễn Thái Ngọc Duy, Jul 14, 2013
  4. 03/46 pathspec: i18n-ize error strings in pathspec parsing codeNguyễn Thái Ngọc Duy, Jul 14, 2013
  5. 04/46 pathspec: add copy_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  6. 05/46 Add parse_pathspec() that converts cmdline args to struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  7. 06/46 parse_pathspec: save original pathspec for reportingNguyễn Thái Ngọc Duy, Jul 14, 2013
  8. 07/46 parse_pathspec: add PATHSPEC_PREFER_{CWD,FULL}Nguyễn Thái Ngọc Duy, Jul 14, 2013
  9. 08/46 Convert some get_pathspec() calls to parse_pathspec()Nguyễn Thái Ngọc Duy, Jul 14, 2013
  10. 09/46 parse_pathspec: add special flag for max_depth featureNguyễn Thái Ngọc Duy, Jul 14, 2013
  11. 10/46 parse_pathspec: support stripping submodule trailing slashesNguyễn Thái Ngọc Duy, Jul 14, 2013
  12. 11/46 parse_pathspec: support stripping/checking submodule pathsNguyễn Thái Ngọc Duy, Jul 14, 2013
  13. 12/46 parse_pathspec: support prefixing original patternsNguyễn Thái Ngọc Duy, Jul 14, 2013
  14. 13/46 Guard against new pathspec magic in pathspec matching codeNguyễn Thái Ngọc Duy, Jul 14, 2013
  15. 14/46 clean: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  16. 15/46 commit: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  17. 16/46 status: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  18. 17/46 rerere: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  19. 18/46 checkout: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  20. 19/46 rm: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  21. 20/46 ls-files: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  22. 21/46 archive: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  23. 22/46 check-ignore: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  24. 23/46 add: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  25. 24/46 reset: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  26. 25/46 line-log: convert to use parse_pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  27. 26/46 Convert read_cache_preload() to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  28. 27/46 Convert run_add_interactive to use struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  29. 28/46 Convert unmerge_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  30. 29/46 checkout: convert read_tree_some to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  31. 30/46 Convert report_path_error to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  32. 31/46 Convert refresh_index to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  33. 32/46 Convert {read,fill}_directory to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  34. 33/46 Convert add_files_to_cache to take struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  35. 34/46 Convert common_prefix() to use struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  36. 35/46 Remove diff_tree_{setup,release}_pathsNguyễn Thái Ngọc Duy, Jul 14, 2013
  37. 36/46 Remove init_pathspec() in favor of parse_pathspec()Nguyễn Thái Ngọc Duy, Jul 14, 2013
  38. 37/46 Remove match_pathspec() in favor of match_pathspec_depth()Nguyễn Thái Ngọc Duy, Jul 14, 2013
  39. 38/46 tree-diff: remove the use of pathspec's raw[] in follow-rename codepathNguyễn Thái Ngọc Duy, Jul 14, 2013
  40. 39/46 Rename field "raw" to "_raw" in struct pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  41. 40/46 parse_pathspec: make sure the prefix part is wildcard-freeNguyễn Thái Ngọc Duy, Jul 14, 2013
  42. 41/46 parse_pathspec: preserve prefix length via PATHSPEC_PREFIX_ORIGINNguyễn Thái Ngọc Duy, Jul 14, 2013
  43. 42/46 Kill limit_pathspec_to_literal() as it's only used by parse_pathspec()Nguyễn Thái Ngọc Duy, Jul 14, 2013
  44. 43/46 pathspec: support :(literal) syntax for noglob pathspecNguyễn Thái Ngọc Duy, Jul 14, 2013
  45. 44/46 pathspec: make --literal-pathspecs disable pathspec magicNguyễn Thái Ngọc Duy, Jul 14, 2013
  46. 45/46 pathspec: support :(glob) syntaxNguyễn Thái Ngọc Duy, Jul 14, 2013
  47. 46/46 parse_pathspec: accept :(icase)path syntaxNguyễn Thái Ngọc Duy, Jul 14, 2013
  48. Eric SunshineJul 14, 2013
  49. Junio C HamanoJul 15, 2013
  50. Junio C HamanoJul 15, 2013
  51. "git fmt-merge-msg" usage (was [PATCH v2 00/46] "struct pathspec" conversion and :(glob) and :(icase))Michael Haggerty, Aug 16, 2013
  52. Junio C HamanoAug 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.