[PATCH 1/2] builtin/checkout.c: don't leak memory in check_tracking_name
- From
- Brandon Casey <bcasey@nvidia.com>
- Date
- Jun 18, 2013, 01:40 UTC
- Message-ID
- <1371519650-17869-1-git-send-email-bcasey@nvidia.com>
From: Brandon Casey <drafnel@gmail.com>
remote_find_tracking() populates the query struct with an allocated string in the dst member. So, we do not need to xstrdup() the string, since we can transfer ownership from the query struct (which will go out of scope at the end of this function) to our callback struct, but we must free the string if it will not be used so we will not leak memory.
Let's do so.
Signed-off-by: Brandon Casey <drafnel@gmail.com> --- builtin/checkout.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c index f5b50e5..3be0018 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -838,13 +838,16 @@ static int check_tracking_name(struct remote *remote, void *cb_data) memset(&query, 0, sizeof(struct refspec)); query.src = cb->src_ref; if (remote_find_tracking(remote, &query) || - get_sha1(query.dst, cb->dst_sha1)) + get_sha1(query.dst, cb->dst_sha1)) { + free(query.dst); return 0; + } if (cb->dst_ref) { + free(query.dst); cb->unique = 0; return 0; } - cb->dst_ref = xstrdup(query.dst); + cb->dst_ref = query.dst; return 0; }
-- 1.8.2.415.g63cec41