git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] sh-setup: add new peel_committish() helper

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 14, 2013, 13:17 UTC
Message-ID
<1371215872-9796-3-git-send-email-artagnon@gmail.com>
In-Reply-To
<1371215872-9796-1-git-send-email-artagnon@gmail.com>

The normal way to check whether a certain revision resolves to a valid commit is:

  $ git rev-parse --verify $REV^0

Unfortunately, this does not work when $REV is of the type :/quuxery. Write a helper to work around this limitation.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 git-sh-setup.sh | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 2f78359..7a964ad 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -313,3 +313,15 @@ then
 	}
 	: ${GIT_OBJECT_DIRECTORY="$GIT_DIR/objects"}
 fi
+
+peel_committish () {
+	case "$1" in
+	:/*)
+		peeltmp=$(git rev-parse --verify "$1") &&
+		git rev-parse --verify "${peeltmp}^0"
+		;;
+	*)
+		git rev-parse --verify "${1}^0"
+		;;
+	esac
+}
-- 
1.8.3.1.381.g12ca056.dirty
Previous: Ramkumar RamachandraNext: Philip Oakley
Message 3 of 10 in “Get rebase to work with :/foomery committish”
  1. 0/3 Get rebase to work with :/foomery committishRamkumar Ramachandra, Jun 14, 2013
  2. 1/3 t/rebase: add failing tests for a peculiar revisionRamkumar Ramachandra, Jun 14, 2013
  3. 2/3 sh-setup: add new peel_committish() helperRamkumar Ramachandra, Jun 14, 2013
  4. Philip OakleyJun 14, 2013
  5. Ramkumar RamachandraJun 14, 2013
  6. Philip OakleyJun 14, 2013
  7. 3/3 rebase: use peel_committish() where appropriateRamkumar Ramachandra, Jun 14, 2013
  8. Junio C HamanoJun 14, 2013
  9. Ramkumar RamachandraJun 15, 2013
  10. Junio C HamanoJun 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.