git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] am: handle stray $dotest directory case

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 13, 2013, 14:17 UTC
Message-ID
<1371133031-28049-1-git-send-email-artagnon@gmail.com>
The following bug has been observed since rr/rebase-autostash:
  $ git am  # no input file
  ^C
  $ git am --abort
  Resolve operation not in progress, we are not resuming.
This happens because the following test fails:
  test -d "$dotest" && test -f "$dotest/last" && test -f "$dotest/next"

and am precludes the possibility of a stray $dotest directory existing (when $dotest/{last,next} are not present).

Fix the bug by checking for a stray $dotest directory explicitly and removing it on --abort.

Reported-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 git-am.sh | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/git-am.sh b/git-am.sh
index 1cf3d1d..f46a123 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -506,6 +506,11 @@ then
 	esac
 	rm -f "$dotest/dirtyindex"
 else
+	# Possible stray $dotest directory
+	if test -d "$dotest" && test t = "$abort"; then
+		clean_abort
+	fi
+
 	# Make sure we are not given --skip, --resolved, nor --abort
 	test "$skip$resolved$abort" = "" ||
 		die "$(gettext "Resolve operation not in progress, we are not resuming.")"
-- 
1.8.3.1.379.ged35616
Next: Junio C Hamano
Message 1 of 6 in “am: handle stray $dotest directory case”
  1. am: handle stray $dotest directory caseRamkumar Ramachandra, Jun 13, 2013
  2. Junio C HamanoJun 13, 2013
  3. Ramkumar RamachandraJun 13, 2013
  4. Junio C HamanoJun 13, 2013
  5. Ramkumar RamachandraJun 13, 2013
  6. Junio C HamanoJun 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.