git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 16/36] cherry-pick: store rewritten commits

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 9, 2013, 19:24 UTC
Message-ID
<1370805890-3453-17-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1370805890-3453-1-git-send-email-felipe.contreras@gmail.com>
Will be useful for the next commits.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 builtin/sequencer.c | 23 ++++++++++++++++++++++-
 builtin/sequencer.h |  1 +
 2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/builtin/sequencer.c b/builtin/sequencer.c
index 2b1b30a..24034f2 100644
--- a/builtin/sequencer.c
+++ b/builtin/sequencer.c
@@ -15,9 +15,12 @@
 #include "refs.h"
 #include "argv-array.h"
 #include "log-tree.h"
+#include "rewrite.h"
 
 #define GIT_REFLOG_ACTION "GIT_REFLOG_ACTION"
 
+static struct rewritten rewritten;
+
 static void remove_sequencer_state(void)
 {
 	struct strbuf seq_dir = STRBUF_INIT;
@@ -555,6 +558,14 @@ static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
 	if (!opts->no_commit)
 		res = run_git_commit(defmsg, opts, allow);
 
+	if (!res && opts->action == REPLAY_PICK) {
+		unsigned char to[20];
+
+		if (read_ref("HEAD", to))
+			goto leave;
+
+		add_rewritten(&rewritten, commit->object.sha1, to);
+	}
 leave:
 	free_message(&msg);
 	free(defmsg);
@@ -917,9 +928,12 @@ static int pick_commits(struct commit_list *todo_list, struct replay_opts *opts)
 	for (cur = todo_list; cur; cur = cur->next) {
 		save_todo(cur, opts);
 		res = do_pick_commit(cur->item, opts);
-		if (res)
+		if (res) {
+			if (opts->action == REPLAY_PICK)
+				store_rewritten(&rewritten, git_path(SEQ_REWR_FILE));
 			return res;
 		}
+	}
 
 	/*
 	 * Sequence of picks finished successfully; cleanup by
@@ -947,6 +961,8 @@ static int sequencer_continue(struct replay_opts *opts)
 		return continue_single_pick();
 	read_populate_opts(&opts);
 	read_populate_todo(&todo_list, opts);
+	if (opts->action == REPLAY_PICK)
+		load_rewritten(&rewritten, git_path(SEQ_REWR_FILE));
 
 	/* Verify that the conflict has been resolved */
 	if (file_exists(git_path("CHERRY_PICK_HEAD")) ||
@@ -957,6 +973,11 @@ static int sequencer_continue(struct replay_opts *opts)
 	}
 	if (index_differs_from("HEAD", 0))
 		return error_dirty_index(opts);
+	if (opts->action == REPLAY_PICK) {
+		unsigned char to[20];
+		if (!read_ref("HEAD", to))
+			add_rewritten(&rewritten, todo_list->item->object.sha1, to);
+	}
 	todo_list = todo_list->next;
 	return pick_commits(todo_list, opts);
 }
diff --git a/builtin/sequencer.h b/builtin/sequencer.h
index e69495a..63ba274 100644
--- a/builtin/sequencer.h
+++ b/builtin/sequencer.h
@@ -5,6 +5,7 @@
 #define SEQ_HEAD_FILE	"sequencer/head"
 #define SEQ_TODO_FILE	"sequencer/todo"
 #define SEQ_OPTS_FILE	"sequencer/opts"
+#define SEQ_REWR_FILE	"sequencer/rewritten"
 
 enum replay_action {
 	REPLAY_REVERT,
-- 
1.8.3.698.g079b096
Previous: Felipe ContrerasNext: Felipe Contreras
Message 17 of 42 in “Massive improvents to rebase and cherry-pick”
  1. 00/36 Massive improvents to rebase and cherry-pickFelipe Contreras, Jun 9, 2013
  2. 01/36 build: generate and clean test scriptsFelipe Contreras, Jun 9, 2013
  3. 02/36 build: do not install git-remote-testgitFelipe Contreras, Jun 9, 2013
  4. 03/36 build: trivial cleanupFelipe Contreras, Jun 9, 2013
  5. 04/36 build: add builtin libFelipe Contreras, Jun 9, 2013
  6. 05/36 log-tree: remove dependency from sequencerFelipe Contreras, Jun 9, 2013
  7. 06/36 Move sequencer to builtinFelipe Contreras, Jun 9, 2013
  8. 07/36 unpack-trees: plug a memory leakFelipe Contreras, Jun 9, 2013
  9. 08/36 read-cache: plug a few leaksFelipe Contreras, Jun 9, 2013
  10. 09/36 sequencer: remove useless indentationFelipe Contreras, Jun 9, 2013
  11. 10/36 sequencer: trivial fixFelipe Contreras, Jun 9, 2013
  12. 11/36 cherry-pick: don't barf when there's nothing to doFelipe Contreras, Jun 9, 2013
  13. 12/36 cherry-pick: add --skip-empty optionFelipe Contreras, Jun 9, 2013
  14. 13/36 revert/cherry-pick: add --quiet optionFelipe Contreras, Jun 9, 2013
  15. 14/36 revert/cherry-pick: add --skip optionFelipe Contreras, Jun 9, 2013
  16. 15/36 builtin: add rewrite helperFelipe Contreras, Jun 9, 2013
  17. 16/36 cherry-pick: store rewritten commitsFelipe Contreras, Jun 9, 2013
  18. 17/36 cherry-pick: don't store skipped commitFelipe Contreras, Jun 9, 2013
  19. 18/36 builtin: move run_rewrite_hook() to rewrite.cFelipe Contreras, Jun 9, 2013
  20. 19/36 builtin: add copy_rewrite_notes()Felipe Contreras, Jun 9, 2013
  21. 20/36 cherry-pick: copy notes and run hooksFelipe Contreras, Jun 9, 2013
  22. 21/36 cherry-pick: add --action-name optionFelipe Contreras, Jun 9, 2013
  23. 22/36 cherry-pick: remember rerere-autoupdateFelipe Contreras, Jun 9, 2013
  24. 23/36 rebase: split the cherry-pick stuffFelipe Contreras, Jun 9, 2013
  25. 24/36 rebase: cherry-pick: fix mode storageFelipe Contreras, Jun 9, 2013
  26. 25/36 rebase: cherry-pick: fix sequence continuationFelipe Contreras, Jun 9, 2013
  27. 26/36 rebase: cherry-pick: fix abort of cherry modeFelipe Contreras, Jun 9, 2013
  28. 27/36 rebase: cherry-pick: fix command invocationsFelipe Contreras, Jun 9, 2013
  29. 28/36 rebase: cherry-pick: fix status messagesFelipe Contreras, Jun 9, 2013
  30. 29/36 rebase: cherry-pick: automatically commit stageFelipe Contreras, Jun 9, 2013
  31. 30/36 rebase: cherry-pick: set correct action-nameFelipe Contreras, Jun 9, 2013
  32. 31/36 rebase: trivial cleanupFelipe Contreras, Jun 9, 2013
  33. 32/36 rebase: use 'cherrypick' mode instead of 'am'Felipe Contreras, Jun 9, 2013
  34. 33/36 rebase: cherry-pick: fix for shell promptFelipe Contreras, Jun 9, 2013
  35. 34/36 rebase: cherry-pick: add merge optionsFelipe Contreras, Jun 9, 2013
  36. 35/36 rebase: remove merge modeFelipe Contreras, Jun 9, 2013
  37. 36/36 rebase: cherry-pick: add copyrightFelipe Contreras, Jun 9, 2013
  38. Felipe ContrerasJun 9, 2013
  39. Phil HordJun 10, 2013
  40. Felipe ContrerasJun 10, 2013
  41. Phil HordJun 11, 2013
  42. Felipe ContrerasJun 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.