git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/9] sequencer: trivial fix

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jun 6, 2013, 08:58 UTC
Message-ID
<1370509144-31974-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1370509144-31974-1-git-send-email-felipe.contreras@gmail.com>
We should free objects before leaving.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 sequencer.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index b4989ba..f7be7d8 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -628,8 +628,10 @@ static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
 	}
 
 	allow = allow_empty(opts, commit);
-	if (allow < 0)
-		return allow;
+	if (allow < 0) {
+		res = allow;
+		goto leave;
+	}
 	if (!opts->no_commit)
 		res = run_git_commit(defmsg, opts, allow);
 
-- 
1.8.3.698.g079b096
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 18 in “cherry-pick: improvements”
  1. 0/9 cherry-pick: improvementsFelipe Contreras, Jun 6, 2013
  2. 1/9 sequencer: remove useless indentationFelipe Contreras, Jun 6, 2013
  3. 2/9 sequencer: trivial fixFelipe Contreras, Jun 6, 2013
  4. 3/9 cherry-pick: add --skip-empty optionFelipe Contreras, Jun 6, 2013
  5. Junio C HamanoJun 6, 2013
  6. Felipe ContrerasJun 6, 2013
  7. Junio C HamanoJun 6, 2013
  8. Junio C HamanoJun 6, 2013
  9. Felipe ContrerasJun 7, 2013
  10. 4/9 cherry-pick: store rewritten commitsFelipe Contreras, Jun 6, 2013
  11. 5/9 sequencer: run post-rewrite hookFelipe Contreras, Jun 6, 2013
  12. Junio C HamanoJun 6, 2013
  13. Felipe ContrerasJun 9, 2013
  14. 6/9 cherry-pick: add support to copy notesFelipe Contreras, Jun 6, 2013
  15. Felipe ContrerasJun 6, 2013
  16. 7/9 revert/cherry-pick: add --quiet optionFelipe Contreras, Jun 6, 2013
  17. 8/9 revert/cherry-pick: add --skip optionFelipe Contreras, Jun 6, 2013
  18. 9/9 cherry-pick: don't barf when there's nothing to doFelipe Contreras, Jun 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.