git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/6] t5000: use check_tar for prefix test

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 20, 2013, 09:58 UTC
Message-ID
<1369043909-59207-5-git-send-email-rene.scharfe@lsrfire.ath.cx>
In-Reply-To
<1369043909-59207-1-git-send-email-rene.scharfe@lsrfire.ath.cx>

Perform the full range of checks against all archived files instead of looking only at the file type of a few of them. Also add a test of a git archive with a prefix ending in with a slash, i.e. adding a full directory level.

Signed-off-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 t/t5000-tar-tree.sh | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
index 8337a1f..5a9b570 100755
--- a/t/t5000-tar-tree.sh
+++ b/t/t5000-tar-tree.sh
@@ -103,6 +103,18 @@ test_expect_success \
 
 check_tar b
 
+test_expect_success 'git archive --prefix=prefix/' '
+	git archive --prefix=prefix/ HEAD >with_prefix.tar
+'
+
+check_tar with_prefix prefix/
+
+test_expect_success 'git-archive --prefix=olde-' '
+	git archive --prefix=olde- HEAD >with_olde-prefix.tar
+'
+
+check_tar with_olde-prefix olde-
+
 test_expect_success \
     'git tar-tree' \
     'git tar-tree HEAD >b2.tar'
@@ -180,18 +192,6 @@ test_expect_success 'clients cannot access unreachable commits' '
 	test_must_fail git archive --remote=. $sha1 >remote.tar
 '
 
-test_expect_success 'git-archive --prefix=olde-' '
-	git archive --prefix=olde- >h.tar HEAD &&
-	(
-		mkdir h &&
-		cd h &&
-		"$TAR" xf - <../h.tar
-	) &&
-	test -d h/olde-a &&
-	test -d h/olde-a/bin &&
-	test -f h/olde-a/bin/sh
-'
-
 test_expect_success 'setup tar filters' '
 	git config tar.tar.foo.command "tr ab ba" &&
 	git config tar.bar.command "tr ab ba" &&
-- 
1.8.2.3
Previous: René ScharfeNext: René Scharfe
Message 9 of 15 in “t5000: add test for pax extended header generation”
  1. 0/6 t5000: add test for pax extended header generationRené Scharfe, May 20, 2013
  2. 1/6 t5000: integrate export-subst tests into regular testsRené Scharfe, May 20, 2013
  3. Eric SunshineMay 20, 2013
  4. René ScharfeMay 20, 2013
  5. 2/6 t5000, t5003: create directories for extracted files lazilyRené Scharfe, May 20, 2013
  6. 3/6 t5000: factor out check_tarRené Scharfe, May 20, 2013
  7. Eric SunshineMay 20, 2013
  8. René ScharfeMay 20, 2013
  9. 4/6 t5000: use check_tar for prefix testRené Scharfe, May 20, 2013
  10. 5/6 t5000: simplify tar-tree testsRené Scharfe, May 20, 2013
  11. 6/6 t5000: test long filenamesRené Scharfe, May 20, 2013
  12. Eric SunshineMay 20, 2013
  13. (unknown)Marty Landman, May 20, 2013
  14. René ScharfeMay 20, 2013
  15. Junio C HamanoMay 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.