git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 13/47] remote-helpers: tests: general improvements

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 14, 2013, 04:36 UTC
Message-ID
<1368506230-19614-14-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1368506230-19614-1-git-send-email-felipe.contreras@gmail.com>
So that we don't need a temporary directory.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/test-bzr.sh       | 21 ++++++++++----------
 contrib/remote-helpers/test-hg-bidi.sh   | 15 +++++----------
 contrib/remote-helpers/test-hg-hg-git.sh | 33 +++++++++++---------------------
 contrib/remote-helpers/test-hg.sh        |  7 +++++--
 4 files changed, 31 insertions(+), 45 deletions(-)
diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh
index 6332050..2774f41 100755
--- a/contrib/remote-helpers/test-bzr.sh
+++ b/contrib/remote-helpers/test-bzr.sh
@@ -190,9 +190,11 @@ test_expect_success 'different authors' '
 	test_cmp expected actual
 '
 
+# cleanup previous stuff
+rm -rf bzrrepo gitrepo
+
 test_expect_success 'fetch utf-8 filenames' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp && LC_ALL=C" &&
+	test_when_finished "rm -rf bzrrepo gitrepo && LC_ALL=C" &&
 
 	LC_ALL=en_US.UTF-8
 	export LC_ALL
@@ -223,8 +225,9 @@ test_expect_success 'fetch utf-8 filenames' '
 '
 
 test_expect_success 'push utf-8 filenames' '
+	test_when_finished "rm -rf bzrrepo gitrepo && LC_ALL=C" &&
+
 	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp && LC_ALL=C" &&
 
 	LC_ALL=en_US.UTF-8
 	export LC_ALL
@@ -255,8 +258,7 @@ test_expect_success 'push utf-8 filenames' '
 '
 
 test_expect_success 'pushing a merge' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf bzrrepo gitrepo" &&
 
 	(
 	bzr init bzrrepo &&
@@ -297,8 +299,7 @@ origin/trunk
 EOF
 
 test_expect_success 'proper bzr repo' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf bzrrepo gitrepo" &&
 
 	bzr init-repo bzrrepo &&
 
@@ -323,13 +324,11 @@ test_expect_success 'proper bzr repo' '
 	git for-each-ref --format "%(refname:short)" refs/remotes/origin > ../actual
 	) &&
 
-	test_cmp ../expected actual
+	test_cmp expected actual
 '
 
 test_expect_success 'strip' '
-	# Do not imitate this style; always chdir inside a subshell instead
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf bzrrepo gitrepo" &&
 
 	(
 	bzr init bzrrepo &&
diff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.sh
index f569697..490a395 100755
--- a/contrib/remote-helpers/test-hg-bidi.sh
+++ b/contrib/remote-helpers/test-hg-bidi.sh
@@ -77,8 +77,7 @@ setup () {
 setup
 
 test_expect_success 'encoding' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -115,8 +114,7 @@ test_expect_success 'encoding' '
 '
 
 test_expect_success 'file removal' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -148,8 +146,7 @@ test_expect_success 'file removal' '
 '
 
 test_expect_success 'git tags' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -177,8 +174,7 @@ test_expect_success 'git tags' '
 '
 
 test_expect_success 'hg branch' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -214,8 +210,7 @@ test_expect_success 'hg branch' '
 '
 
 test_expect_success 'hg tags' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
diff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh
index 7f579c8..6f0819c 100755
--- a/contrib/remote-helpers/test-hg-hg-git.sh
+++ b/contrib/remote-helpers/test-hg-hg-git.sh
@@ -114,8 +114,7 @@ setup () {
 setup
 
 test_expect_success 'executable bit' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -150,8 +149,7 @@ test_expect_success 'executable bit' '
 '
 
 test_expect_success 'symlink' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -181,8 +179,7 @@ test_expect_success 'symlink' '
 '
 
 test_expect_success 'merge conflict 1' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	hg init hgrepo1 &&
@@ -216,8 +213,7 @@ test_expect_success 'merge conflict 1' '
 '
 
 test_expect_success 'merge conflict 2' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	hg init hgrepo1 &&
@@ -251,8 +247,7 @@ test_expect_success 'merge conflict 2' '
 '
 
 test_expect_success 'converged merge' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	hg init hgrepo1 &&
@@ -287,8 +282,7 @@ test_expect_success 'converged merge' '
 '
 
 test_expect_success 'encoding' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -327,8 +321,7 @@ test_expect_success 'encoding' '
 '
 
 test_expect_success 'file removal' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -367,8 +360,7 @@ test_expect_success 'file removal' '
 '
 
 test_expect_success 'git tags' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	(
 	git init -q gitrepo &&
@@ -394,8 +386,7 @@ test_expect_success 'git tags' '
 '
 
 test_expect_success 'hg author' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	for x in hg git; do
 		(
@@ -461,8 +452,7 @@ test_expect_success 'hg author' '
 '
 
 test_expect_success 'hg branch' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	for x in hg git; do
 		(
@@ -498,8 +488,7 @@ test_expect_success 'hg branch' '
 '
 
 test_expect_success 'hg tags' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf gitrepo* hgrepo*" &&
 
 	for x in hg git; do
 		(
diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh
index 8d1154b..043f6c6 100755
--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh
@@ -122,6 +122,9 @@ test_expect_success 'update bookmark' '
 	hg -R hgrepo bookmarks | egrep "devel[	 ]+3:"
 '
 
+# cleanup previous stuff
+rm -rf hgrepo
+
 author_test () {
 	echo $1 >> content &&
 	hg commit -u "$2" -m "add $1" &&
@@ -129,8 +132,7 @@ author_test () {
 }
 
 test_expect_success 'authors' '
-	mkdir -p tmp && cd tmp &&
-	test_when_finished "cd .. && rm -rf tmp" &&
+	test_when_finished "rm -rf hgrepo gitrepo" &&
 
 	(
 	hg init hgrepo &&
@@ -139,6 +141,7 @@ test_expect_success 'authors' '
 	touch content &&
 	hg add content &&
 
+	> ../expected &&
 	author_test alpha "" "H G Wells <wells@example.com>" &&
 	author_test beta "test" "test <unknown>" &&
 	author_test beta "test <test@example.com> (comment)" "test <test@example.com>" &&

-- 
1.8.3.rc1.579.g184e698
Previous: Felipe ContrerasNext: Felipe Contreras
Message 14 of 50 in “remote-hg: fixes for next”
  1. 00/47 remote-hg: fixes for nextFelipe Contreras, May 14, 2013
  2. 01/47 remote-hg: trivial cleanupsFelipe Contreras, May 14, 2013
  3. 02/47 remote-hg: get rid of unused exception checksFelipe Contreras, May 14, 2013
  4. 03/47 remote-hg: enable track-branches in hg-git modeFelipe Contreras, May 14, 2013
  5. 04/47 remote-hg: add new get_config_bool() helperFelipe Contreras, May 14, 2013
  6. 05/47 remote-hg: fix new branch creationFelipe Contreras, May 14, 2013
  7. 06/47 remote-hg: disable forced push by defaultFelipe Contreras, May 14, 2013
  8. 07/47 remote-hg: don't push fake 'master' bookmarkFelipe Contreras, May 14, 2013
  9. 08/47 remote-hg: update bookmarks when pullingFelipe Contreras, May 14, 2013
  10. 09/47 remote-hg: test: be a little more quietFelipe Contreras, May 14, 2013
  11. 10/47 remote-hg: trivial reorganizationFelipe Contreras, May 14, 2013
  12. 11/47 remote-helpers: test: cleanup white-spacesFelipe Contreras, May 14, 2013
  13. 12/47 remote-helpers: test: cleanup styleFelipe Contreras, May 14, 2013
  14. 13/47 remote-helpers: tests: general improvementsFelipe Contreras, May 14, 2013
  15. 14/47 remote-helpers: test: simplify remote URLsFelipe Contreras, May 14, 2013
  16. 15/47 remote-hg: test: simplify previous branch checkoutFelipe Contreras, May 14, 2013
  17. 16/47 remote-hg: load all extensionsFelipe Contreras, May 14, 2013
  18. Eric SunshineMay 14, 2013
  19. 17/47 remote-hg: use a shared repository storeFelipe Contreras, May 14, 2013
  20. 18/47 remote-hg: shuffle some codeFelipe Contreras, May 14, 2013
  21. 19/47 remote-hg: improve node traversingFelipe Contreras, May 14, 2013
  22. 20/47 remote-hg: add version checks to the marksFelipe Contreras, May 14, 2013
  23. 21/47 remote-hg: switch from revisions to SHA-1 noteidsFelipe Contreras, May 14, 2013
  24. 22/47 remote-hg: upgrade version 1 marksFelipe Contreras, May 14, 2013
  25. 23/47 remote-hg: ensure remote rebasing worksFelipe Contreras, May 14, 2013
  26. 24/47 remote-hg: trivial cleanupsFelipe Contreras, May 14, 2013
  27. 25/47 remote-hg: improve progress calculationFelipe Contreras, May 14, 2013
  28. 26/47 remote-hg: always point HEAD to masterFelipe Contreras, May 14, 2013
  29. 27/47 remote-bzr: simplify test checksFelipe Contreras, May 14, 2013
  30. 28/47 remote-hg: add check_bookmark() test helperFelipe Contreras, May 14, 2013
  31. 29/47 remote-hg: add remote testsFelipe Contreras, May 14, 2013
  32. 30/47 remote-hg: add test to push new bookmarkFelipe Contreras, May 14, 2013
  33. 31/47 remote-hg: add test for diverged pushFelipe Contreras, May 14, 2013
  34. 32/47 remote-hg: add test for bookmark divergeFelipe Contreras, May 14, 2013
  35. 33/47 remote-hg: add test for new bookmark specialFelipe Contreras, May 14, 2013
  36. Eric SunshineMay 14, 2013
  37. 34/47 remote-hg: add test for big pushFelipe Contreras, May 14, 2013
  38. 35/47 remote-hg: add test for failed double pushFelipe Contreras, May 14, 2013
  39. 36/47 remote-hg: reorganize bookmark handlingFelipe Contreras, May 14, 2013
  40. 37/47 remote-hg: force remote bookmark push selectivelyFelipe Contreras, May 14, 2013
  41. 38/47 remote-hg: only update necessary revisionsFelipe Contreras, May 14, 2013
  42. 39/47 remote-hg: implement custom push()Felipe Contreras, May 14, 2013
  43. 40/47 remote-hg: implement custom checkheads()Felipe Contreras, May 14, 2013
  44. 41/47 remote-hg: pass around revision refsFelipe Contreras, May 14, 2013
  45. 42/47 remote-hg: check diverged bookmarksFelipe Contreras, May 14, 2013
  46. 43/47 remote-hg: simplify branch_tip()Felipe Contreras, May 14, 2013
  47. 44/47 remote-hg: improve branch listingFelipe Contreras, May 14, 2013
  48. 45/47 remote-hg: use remote 'default' not local oneFelipe Contreras, May 14, 2013
  49. 46/47 remote-hg: improve lightweight tag authorFelipe Contreras, May 14, 2013
  50. 47/47 remote-hg: remove files before modificationsFelipe Contreras, May 14, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.