[PATCH 3/6] stash: simplify option parser for create
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- May 13, 2013, 12:45 UTC
- Message-ID
- <1368449154-21882-4-git-send-email-artagnon@gmail.com>
- In-Reply-To
- <1368449154-21882-1-git-send-email-artagnon@gmail.com>
The option parser for create unnecessarily checks "$1" inside a case statement that matches "$1" in the first place. Also, use "$@", not "$*", as our caller is expecting "$1" "$2", not "$1c$2" (where c is the first character of IFS).
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- git-stash.sh | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh index bbefdf6..0ede313 100755 --- a/git-stash.sh +++ b/git-stash.sh @@ -546,11 +546,8 @@ clear) clear_stash "$@" ;; create) - if test $# -gt 0 && test "$1" = create - then - shift - fi - create_stash "$*" && echo "$w_commit" + shift + create_stash "$@" && echo "$w_commit" ;; drop) shift
-- 1.8.3.rc1.57.g4ac1522