git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/6] remote-hg: disable forced push by default

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 10, 2013, 20:59 UTC
Message-ID
<1368219566-1399-2-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1368219566-1399-1-git-send-email-felipe.contreras@gmail.com>

In certain situations we might end up pushing garbage revisions (e.g. in a rebase), and the patches to deal with that haven't been merged yet.

So let's disable forced pushes by default.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/git-remote-hg | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 96ad30d..84901e9 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -908,7 +908,7 @@ def main(args):
 
     hg_git_compat = False
     track_branches = True
-    force_push = True
+    force_push = False
 
     try:
         if get_config('remote-hg.hg-git-compat') == 'true\n':
@@ -916,8 +916,8 @@ def main(args):
             track_branches = False
         if get_config('remote-hg.track-branches') == 'false\n':
             track_branches = False
-        if get_config('remote-hg.force-push') == 'false\n':
-            force_push = False
+        if get_config('remote-hg.force-push') == 'true\n':
+            force_push = True
     except subprocess.CalledProcessError:
         pass
 
-- 
1.8.3.rc1.579.g184e698
Previous: Felipe ContrerasNext: Felipe Contreras
Message 2 of 8 in “remote-hg: fixes and cleanups”
  1. 0/6 remote-hg: fixes and cleanupsFelipe Contreras, May 10, 2013
  2. 1/6 remote-hg: disable forced push by defaultFelipe Contreras, May 10, 2013
  3. 2/6 remote-hg: don't push fake 'master' bookmarkFelipe Contreras, May 10, 2013
  4. 3/6 remote-hg: update bookmarks when pullingFelipe Contreras, May 10, 2013
  5. 4/6 remote-hg: test: be a little more quietFelipe Contreras, May 10, 2013
  6. 5/6 remote-hg: fix new branch creationFelipe Contreras, May 10, 2013
  7. 6/6 remote-hg: trivial reorganizationFelipe Contreras, May 10, 2013
  8. Felipe ContrerasMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.