git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] completion: synchronize zsh wrapper

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 8, 2013, 07:37 UTC
Message-ID
<1367998621-12582-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1367998621-12582-1-git-send-email-felipe.contreras@gmail.com>
So it's closer to the full zsh wrapper.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 84dbf19..b61f6c2 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2663,7 +2663,7 @@ if [[ -n ${ZSH_VERSION-} ]]; then
 				--*=*|*.) ;;
 				*) c="$c " ;;
 				esac
-				array[$#array+1]="$c"
+				array+=("$c")
 			done
 			compset -P '*[=:]'
 			compadd -Q -S '' -p "${2-}" -a -- array && _ret=0
@@ -2696,7 +2696,7 @@ if [[ -n ${ZSH_VERSION-} ]]; then
 		prev=${words[CURRENT-1]}
 		let cword=CURRENT-1
 		emulate ksh -c __${service}_main
-		let _ret && _default -S '' && _ret=0
+		let _ret && _default && _ret=0
 		return _ret
 	}
 
-- 
1.8.3.rc1.553.gac13664
Previous: Felipe Contreras
Message 3 of 3 in “completion: zsh wrapper cleanups”
  1. 0/2 completion: zsh wrapper cleanupsFelipe Contreras, May 8, 2013
  2. 1/2 completion: cleanup zsh wrapperFelipe Contreras, May 8, 2013
  3. 2/2 completion: synchronize zsh wrapperFelipe Contreras, May 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.