git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 08/20] remote-hg: split bookmark handling

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 8, 2013, 17:13 UTC
Message-ID
<1365441214-21096-9-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1365441214-21096-1-git-send-email-felipe.contreras@gmail.com>
Will be useful for remote bookmarks.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/git-remote-hg | 39 +++++++++++++++++++++++-------------
 1 file changed, 25 insertions(+), 14 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 874ccd4..6901689 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -685,6 +685,8 @@ def parse_tag(parser):
 def do_export(parser):
     global parsed_refs, bmarks, peer
 
+    p_bmarks = []
+
     parser.next()
 
     for line in parser.each_block('done'):
@@ -706,20 +708,9 @@ def do_export(parser):
             pass
         elif ref.startswith('refs/heads/'):
             bmark = ref[len('refs/heads/'):]
-            if bmark in bmarks:
-                old = bmarks[bmark].hex()
-            else:
-                old = ''
-
-            if bmark == 'master' and 'master' not in parser.repo._bookmarks:
-                # fake bookmark
-                print "ok %s" % ref
-                continue
-
-            if not bookmarks.pushbookmark(parser.repo, bmark, old, node):
-                print "error %s" % ref
-                continue
-
+            p_bmarks.append((bmark, node))
+            # handle below
+            continue
         elif ref.startswith('refs/tags/'):
             tag = ref[len('refs/tags/'):]
             parser.repo.tag([tag], node, None, True, None, {})
@@ -731,6 +722,26 @@ def do_export(parser):
     if peer:
         parser.repo.push(peer, force=False)
 
+    # handle bookmarks
+    for bmark, node in p_bmarks:
+        ref = 'refs/heads' + bmark
+
+        if bmark in bmarks:
+            old = bmarks[bmark].hex()
+        else:
+            old = ''
+
+        if bmark == 'master' and 'master' not in parser.repo._bookmarks:
+            # fake bookmark
+            print "ok %s" % ref
+            continue
+
+        if not bookmarks.pushbookmark(parser.repo, bmark, old, node):
+            print "error %s" % ref
+            continue
+
+        print "ok %s" % ref
+
     print
 
 def fix_path(alias, repo, orig_url):
-- 
1.8.2
Previous: Felipe ContrerasNext: Felipe Contreras
Message 9 of 24 in “remote-hg: general updates”
  1. 00/20 remote-hg: general updatesFelipe Contreras, Apr 8, 2013
  2. 01/20 remote-hg: trivial cleanupsFelipe Contreras, Apr 8, 2013
  3. 02/20 remote-hg: add missing config variable in docFelipe Contreras, Apr 8, 2013
  4. 03/20 remote-hg: properly report errors on bookmark pushesFelipe Contreras, Apr 8, 2013
  5. 04/20 remote-hg: fix for files with spacesFelipe Contreras, Apr 8, 2013
  6. 05/20 remote-hg: make sure fake bookmarks are updatedFelipe Contreras, Apr 8, 2013
  7. 06/20 remote-hg: trivial test cleanupsFelipe Contreras, Apr 8, 2013
  8. 07/20 remote-hg: redirect buggy mercurial outputFelipe Contreras, Apr 8, 2013
  9. 08/20 remote-hg: split bookmark handlingFelipe Contreras, Apr 8, 2013
  10. Felipe ContrerasApr 10, 2013
  11. Junio C HamanoApr 10, 2013
  12. 09/20 remote-hg: refactor exportFelipe Contreras, Apr 8, 2013
  13. 10/20 remote-hg: update remote bookmarksFelipe Contreras, Apr 8, 2013
  14. 11/20 remote-hg: update tags globallyFelipe Contreras, Apr 8, 2013
  15. 12/20 remote-hg: push to the appropriate branchFelipe Contreras, Apr 8, 2013
  16. Felipe ContrerasApr 10, 2013
  17. 13/20 remote-hg: force remote pushFelipe Contreras, Apr 8, 2013
  18. 14/20 remote-hg: show more proper errorsFelipe Contreras, Apr 8, 2013
  19. 15/20 remote-hg: add basic author testsFelipe Contreras, Apr 8, 2013
  20. 16/20 remote-hg: add simple mail testFelipe Contreras, Apr 8, 2013
  21. 17/20 remote-hg: add 'insecure' optionFelipe Contreras, Apr 8, 2013
  22. 18/20 remote-hg: fix bad state issueFelipe Contreras, Apr 8, 2013
  23. 19/20 remote-hg: document location of stored hg repositoryFelipe Contreras, Apr 8, 2013
  24. 20/20 remote-hg: fix bad file pathsFelipe Contreras, Apr 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.