git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] fmt-merge-msg: use core.commentchar in tag signatures completely

From
Ralf Thielow <ralf.thielow@gmail.com>
Date
Apr 7, 2013, 15:25 UTC
Message-ID
<1365348344-1648-2-git-send-email-ralf.thielow@gmail.com>
In-Reply-To
<1365348344-1648-1-git-send-email-ralf.thielow@gmail.com>

Commit eff80a9 (Allow custom "comment char") introduced a custom comment character for commit messages but didn't use it completely in the tag signature part.

This commit fixes that.
Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
---
 builtin/fmt-merge-msg.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c
index 88df93a..1c04070 100644
--- a/builtin/fmt-merge-msg.c
+++ b/builtin/fmt-merge-msg.c
@@ -503,14 +503,18 @@ static void fmt_merge_msg_sigs(struct strbuf *out)
 		} else {
 			if (tag_number == 2) {
 				struct strbuf tagline = STRBUF_INIT;
-				strbuf_addf(&tagline, "\n# %s\n",
-					    origins.items[first_tag].string);
+				strbuf_addch(&tagline, '\n');
+				strbuf_add_commented_lines(&tagline,
+						origins.items[first_tag].string,
+						strlen(origins.items[first_tag].string));
 				strbuf_insert(&tagbuf, 0, tagline.buf,
 					      tagline.len);
 				strbuf_release(&tagline);
 			}
-			strbuf_addf(&tagbuf, "\n# %s\n",
-				    origins.items[i].string);
+			strbuf_addch(&tagbuf, '\n');
+			strbuf_add_commented_lines(&tagbuf,
+					origins.items[i].string,
+					strlen(origins.items[i].string));
 			fmt_tag_signature(&tagbuf, &sig, buf, len);
 		}
 		strbuf_release(&sig);
-- 
1.8.2.470.g21ccebe
Previous: Ralf ThielowNext: Johannes Sixt
Message 2 of 12 in “fmt-merge-msg: respect core.commentchar in people credits”
  1. 1/2 fmt-merge-msg: respect core.commentchar in people creditsRalf Thielow, Apr 7, 2013
  2. 2/2 fmt-merge-msg: use core.commentchar in tag signatures completelyRalf Thielow, Apr 7, 2013
  3. t6200: avoid path mangling issue on WindowsJohannes Sixt, Apr 18, 2013
  4. Junio C HamanoApr 18, 2013
  5. Johannes SixtApr 19, 2013
  6. Junio C HamanoApr 19, 2013
  7. Johannes SixtApr 19, 2013
  8. Junio C HamanoApr 19, 2013
  9. Jonathan NiederApr 21, 2013
  10. Johannes SixtApr 21, 2013
  11. Jonathan NiederApr 21, 2013
  12. Junio C HamanoApr 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.