git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] fix git-p4 client root symlink problems

From
PWPete Wyckoff <pw@padd.com>
Date
Mar 11, 2013, 21:45 UTC
Message-ID
<1363038329-20185-1-git-send-email-pw@padd.com>
In-Reply-To
<5139883C.6080308@viscovery.net>
Update from v1:
    * add SYMLINKS prerequisite to the new symlink test
Thanks Hannes.
Miklós pointed out in
    http://thread.gmane.org/gmane.comp.version-control.git/214915

that when the p4 client root included a symlink, bad things happen. It is fixable, but inconvenient, to use an absolute path in one's p4 client. It's not too hard to be smarter about this in git-p4.

Thanks to Miklós for the patch, and to John for the style suggestions. I wrote a couple of tests to make sure this part doesn't break again.

This is maybe a bug introduced by bf1d68f (git-p4: use absolute directory for PWD env var, 2011-12-09), but that's so long ago that I don't think this is a candidate for maint.

		-- Pete
Miklós Fazekas (1):
  git p4: avoid expanding client paths in chdir
Pete Wyckoff (2):
  git p4 test: make sure P4CONFIG relative path works
  git p4 test: should honor symlink in p4 client root
 git-p4.py               | 29 ++++++++++++++++++++++-------
 t/t9808-git-p4-chdir.sh | 41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 7 deletions(-)
-- 
1.8.2.rc2.65.g92f3e2d
Previous: Johannes SixtNext: Pete Wyckoff
Message 9 of 13 in “git p4: chdir resolves symlinks only for relative paths”
  1. git p4: chdir resolves symlinks only for relative pathsMiklós Fazekas, Jan 29, 2013
  2. Pete WyckoffFeb 3, 2013
  3. Miklós FazekasMar 7, 2013
  4. John KeepingMar 7, 2013
  5. 0/3 fix git-p4 client root symlink problemsPete Wyckoff, Mar 7, 2013
  6. 1/3 git p4 test: make sure P4CONFIG relative path worksPete Wyckoff, Mar 7, 2013
  7. 2/3 git p4 test: should honor symlink in p4 client rootPete Wyckoff, Mar 7, 2013
  8. Johannes SixtMar 8, 2013
  9. 0/3 fix git-p4 client root symlink problemsPete Wyckoff, Mar 11, 2013
  10. 1/3 git p4 test: make sure P4CONFIG relative path worksPete Wyckoff, Mar 11, 2013
  11. 2/3 git p4 test: should honor symlink in p4 client rootPete Wyckoff, Mar 11, 2013
  12. 3/3 git p4: avoid expanding client paths in chdirPete Wyckoff, Mar 11, 2013
  13. 3/3 git p4: avoid expanding client paths in chdirPete Wyckoff, Mar 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.