git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] bundle: Add colons to list headings in "verify"

From
LFLukas Fleischer <git@cryptocrack.de>
Date
Mar 8, 2013, 18:01 UTC
Message-ID
<1362765686-18396-1-git-send-email-git@cryptocrack.de>
In-Reply-To
<1362617796-4120-1-git-send-email-git@cryptocrack.de>

These slightly improve the reading flow by making it obvious that a list follows.

Also, make the wording of both headings consistent by changing "contains %d ref(s)" to "contains this ref"/"contains these %d refs".

Signed-off-by: Lukas Fleischer <git@cryptocrack.de>
---
 bundle.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/bundle.c b/bundle.c
index 65db53b..6210a6b 100644
--- a/bundle.c
+++ b/bundle.c
@@ -183,8 +183,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
 		struct ref_list *r;
 
 		r = &header->references;
-		printf_ln(Q_("The bundle contains %d ref",
-			     "The bundle contains %d refs",
+		printf_ln(Q_("The bundle contains this ref:",
+			     "The bundle contains these %d refs:",
 			     r->nr),
 			  r->nr);
 		list_refs(r, 0, NULL);
@@ -192,8 +192,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
 		if (!r->nr) {
 			printf_ln(_("The bundle records a complete history."));
 		} else {
-			printf_ln(Q_("The bundle requires this ref",
-				     "The bundle requires these %d refs",
+			printf_ln(Q_("The bundle requires this ref:",
+				     "The bundle requires these %d refs:",
 				     r->nr),
 				  r->nr);
 			list_refs(r, 0, NULL);
-- 
1.8.2.rc2.352.g908df73
Previous: Junio C Hamano
Message 4 of 4 in “bundle: Fix "verify" output if history is complete”
  1. 1/2 bundle: Fix "verify" output if history is completeLukas Fleischer, Mar 7, 2013
  2. 2/2 bundle: Add colons to list headings in "verify"Lukas Fleischer, Mar 7, 2013
  3. Junio C HamanoMar 7, 2013
  4. bundle: Add colons to list headings in "verify"Lukas Fleischer, Mar 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.