git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 11/16] contrib/fast-import/import-zips.py: fix broken error message

From
David Aguilar <davvid@gmail.com>
Date
Feb 24, 2013, 00:50 UTC
Message-ID
<1361667024-49776-12-git-send-email-davvid@gmail.com>
In-Reply-To
<1361667024-49776-11-git-send-email-davvid@gmail.com>

The 'sys' module is not imported but all of the bits we want from it are. Adjust the script to not fail when run on old Python versions and fix the inconsistent use of tabs.

Signed-off-by: David Aguilar <davvid@gmail.com>
---
 contrib/fast-import/import-zips.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/fast-import/import-zips.py b/contrib/fast-import/import-zips.py
index f54c65b..b528798 100755
--- a/contrib/fast-import/import-zips.py
+++ b/contrib/fast-import/import-zips.py
@@ -14,9 +14,9 @@ from time import mktime
 from zipfile import ZipFile
 
 if hexversion < 0x01060000:
-        # The limiter is the zipfile module
-        sys.stderr.write("import-zips.py: requires Python 1.6.0 or later.\n")
-        sys.exit(1)
+	# The limiter is the zipfile module
+	stderr.write("import-zips.py: requires Python 1.6.0 or later.\n")
+	exit(1)
 
 if len(argv) < 2:
 	print 'usage:', argv[0], '<zipfile>...'
-- 
1.8.2.rc0.263.g20d9441
Previous: David AguilarNext: David Aguilar
Message 12 of 19 in “use a lowercase "usage:" string”
  1. 00/16 use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  2. 01/16 git-sh-setup: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  3. 02/16 git-svn: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  4. 03/16 git-relink: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  5. 04/16 git-merge-one-file: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  6. 05/16 git-archimport: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  7. 06/16 git-cvsexportcommit: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  8. 07/16 git-cvsimport: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  9. 08/16 git-cvsimport: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  10. 09/16 contrib/credential: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  11. 10/16 contrib/fast-import: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  12. 11/16 contrib/fast-import/import-zips.py: fix broken error messageDavid Aguilar, Feb 24, 2013
  13. 12/16 contrib/fast-import/import-zips.py: use spaces instead of tabsDavid Aguilar, Feb 24, 2013
  14. 13/16 contrib/examples: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  15. 14/16 contrib/hooks/setgitperms.perl: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  16. 15/16 templates/hooks--update.sample: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  17. 16/16 Documentation/user-manual.txt: use a lowercase "usage:" stringDavid Aguilar, Feb 24, 2013
  18. Junio C HamanoFeb 24, 2013
  19. David AguilarFeb 24, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.