git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/8] contrib/subtree: Handle '--prefix' argument with a slash appended

From
David A. Greene <greened@obbligato.org>
Date
Feb 18, 2013, 20:56 UTC
Message-ID
<1361221013-12756-7-git-send-email-greened@obbligato.org>
In-Reply-To
<1361221013-12756-1-git-send-email-greened@obbligato.org>
From: Techlive Zheng <techlivezheng@gmail.com>

'git subtree merge' will fail if the argument of '--prefix' has a slash appended.

Signed-off-by: Techlive Zheng <techlivezheng@gmail.com>
Signed-off-by: David A. Greene <greened@obbligato.org>
---
 contrib/subtree/git-subtree.sh     |    2 +-
 contrib/subtree/t/t7900-subtree.sh |   20 ++++++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
index 6c3929b..1b3df99 100755
--- a/contrib/subtree/git-subtree.sh
+++ b/contrib/subtree/git-subtree.sh
@@ -82,7 +82,7 @@ while [ $# -gt 0 ]; do
 		--annotate) annotate="$1"; shift ;;
 		--no-annotate) annotate= ;;
 		-b) branch="$1"; shift ;;
-		-P) prefix="$1"; shift ;;
+		-P) prefix="${1%/}"; shift ;;
 		-m) message="$1"; shift ;;
 		--no-prefix) prefix= ;;
 		--onto) onto="$1"; shift ;;
diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh
index eee032d..5c6c73d 100755
--- a/contrib/subtree/t/t7900-subtree.sh
+++ b/contrib/subtree/t/t7900-subtree.sh
@@ -255,6 +255,26 @@ test_expect_success 'merge new subproj history into subdir/ with --squash and --
 	)
 '
 
+next_test
+test_expect_success 'merge new subproj history into subdir/ with a slash appended to the argument of --prefix' '
+	test_create_repo "$test_count" &&
+	test_create_repo "$test_count/subproj" &&
+	test_create_commit "$test_count" main1 &&
+	test_create_commit "$test_count/subproj" sub1 &&
+	(
+		cd "$test_count" &&
+		git fetch ./subproj master &&
+		git subtree add --prefix=subdir/ FETCH_HEAD
+	) &&
+	test_create_commit "$test_count/subproj" sub2 &&
+	(
+		cd "$test_count" &&
+		git fetch ./subproj master &&
+		git subtree merge --prefix=subdir/ FETCH_HEAD &&
+		test_equal "$(last_commit_message)" "Merge commit '\''$(git rev-parse FETCH_HEAD)'\''"
+	)
+'
+
 #
 # Tests for 'git subtree split'
 #
-- 
1.7.10.4
Previous: David A. GreeneNext: David A. Greene
Message 10 of 12 in “Subtree Fixes Updates”
  1. David A. GreeneFeb 18, 2013
  2. 1/8 contrib/subtree: Use %B for split subject/bodyDavid A. Greene, Feb 18, 2013
  3. Junio C HamanoFeb 18, 2013
  4. 2/8 contrib/subtree: Fix whitespacesDavid A. Greene, Feb 18, 2013
  5. 3/8 contrib/subtree: Ignore testing directoryDavid A. Greene, Feb 18, 2013
  6. Junio C HamanoFeb 18, 2013
  7. 4/8 contrib/subtree: Code cleaning and refactoringDavid A. Greene, Feb 18, 2013
  8. Junio C HamanoFeb 18, 2013
  9. 5/8 contrib/subtree: Make each test self-containedDavid A. Greene, Feb 18, 2013
  10. 6/8 contrib/subtree: Handle '--prefix' argument with a slash appendedDavid A. Greene, Feb 18, 2013
  11. 7/8 contrib/subtree: Remove --annotateDavid A. Greene, Feb 18, 2013
  12. 8/8 Remove test artifaces from clean ruleDavid A. Greene, Feb 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.