[PATCH 0/3] Fix a portability issue with git-cvsimport
- From
Ben Walton <bdwalton@gmail.com>
- Date
- Feb 9, 2013, 21:46 UTC
- Message-ID
- <1360446418-12280-1-git-send-email-bdwalton@gmail.com>
This is my (long overdue) re-roll of the series that fixes a portability issue with git-cvsimport's use of strftime. It also fixes a but in the original implementation of get_tz (now get_tz_offset).
I ended up taking taking only part of the implementation suggested by Junio.
The only usage of get_tz_offset is by git-cvsimport and Git::SVN::Log currently. There are tests that validate it works currently so I didn't add anything additional. If the git-cvsimport tests are removed, there are no tests remaining that exercise the code full as the SVN tests use UTC times.
Ben Walton (3): Move Git::SVN::get_tz to Git::get_tz_offset Fix get_tz_offset to properly handle DST boundary cases Avoid non-portable strftime format specifiers in git-cvsimport
git-cvsimport.perl | 5 ++++- perl/Git.pm | 23 +++++++++++++++++++++++ perl/Git/SVN.pm | 12 ++---------- perl/Git/SVN/Log.pm | 8 ++++++-- 4 files changed, 35 insertions(+), 13 deletions(-)
-- 1.7.10.4