git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-p4.py: support Python 2.5

From
Brandon Casey <drafnel@gmail.com>
Date
Jan 25, 2013, 20:44 UTC
Message-ID
<1359146641-27810-2-git-send-email-drafnel@gmail.com>
In-Reply-To
<1359146641-27810-1-git-send-email-drafnel@gmail.com>

Python 2.5 and older do not accept None as the first argument to translate() and complain with:

   TypeError: expected a character buffer object

Satisfy this older python by calling maketrans() to generate an empty translation table and supplying that to translate().

This allows git-p4 to be used with Python 2.5.
Signed-off-by: Brandon Casey <bcasey@nvidia.com>
---
 INSTALL   | 2 +-
 git-p4.py | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/INSTALL b/INSTALL
index 28f34bd..fc723b3 100644
--- a/INSTALL
+++ b/INSTALL
@@ -131,7 +131,7 @@ Issues of note:
 	  use English. Under autoconf the configure script will do this
 	  automatically if it can't find libintl on the system.
 
-	- Python version 2.6 or later is needed to use the git-p4
+	- Python version 2.5 or later is needed to use the git-p4
 	  interface to Perforce.
 
  - Some platform specific issues are dealt with Makefile rules,
diff --git a/git-p4.py b/git-p4.py
index 2da5649..4f95d7a 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -768,7 +768,8 @@ def wildcard_encode(path):
     return path
 
 def wildcard_present(path):
-    return path.translate(None, "*#@%") != path
+    from string import maketrans
+    return path.translate(maketrans("",""), "*#@%") != path
 
 class Command:
     def __init__(self):
-- 
1.8.1.1.297.gad3d74e


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
Previous: Brandon CaseyNext: Pete Wyckoff
Message 2 of 8 in “git-p4 support for older python”
  1. 0/2 git-p4 support for older pythonBrandon Casey, Jan 25, 2013
  2. 1/2 git-p4.py: support Python 2.5Brandon Casey, Jan 25, 2013
  3. Pete WyckoffJan 26, 2013
  4. Brandon CaseyJan 26, 2013
  5. 2/2 git-p4.py: support Python 2.4Brandon Casey, Jan 25, 2013
  6. Pete WyckoffJan 26, 2013
  7. Brandon CaseyJan 26, 2013
  8. Junio C HamanoJan 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.