git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/10] log: add log.mailmap configuration option

From
Antoine Pelisse <apelisse@gmail.com>
Date
Jan 5, 2013, 21:26 UTC
Message-ID
<1357421206-5014-11-git-send-email-apelisse@gmail.com>
In-Reply-To
<1357421206-5014-1-git-send-email-apelisse@gmail.com>

Teach "log.mailmap" configuration variable to turn "--use-mailmap" option on to "git log", "git show" and "git whatchanged".

The "--no-use-mailmap" option from the command line can countermand the setting.

Signed-off-by: Antoine Pelisse <apelisse@gmail.com>
---
 Documentation/config.txt |  4 ++++
 builtin/log.c            |  7 +++++++
 t/t4203-mailmap.sh       | 24 ++++++++++++++++++++++++
 3 files changed, 35 insertions(+)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index bf8f911..226362a 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1509,6 +1509,10 @@ log.showroot::
 	Tools like linkgit:git-log[1] or linkgit:git-whatchanged[1], which
 	normally hide the root commit will now show it. True by default.
 
+log.mailmap::
+	If true, makes linkgit:git-log[1], linkgit:git-show[1], and
+	linkgit:git-whatchanged[1] assume `--use-mailmap`.
+
 mailmap.file::
 	The location of an augmenting mailmap file. The default
 	mailmap, located in the root of the repository, is loaded
diff --git a/builtin/log.c b/builtin/log.c
index d2bd8ce..16e6520 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -31,6 +31,7 @@ static int default_abbrev_commit;
 static int default_show_root = 1;
 static int decoration_style;
 static int decoration_given;
+static int use_mailmap_config;
 static const char *fmt_patch_subject_prefix = "PATCH";
 static const char *fmt_pretty;
 
@@ -106,6 +107,7 @@ static void cmd_log_init_finish(int argc, const char **argv, const char *prefix,
 		OPT_END()
 	};
 
+	mailmap = use_mailmap_config;
 	argc = parse_options(argc, argv, prefix,
 			     builtin_log_options, builtin_log_usage,
 			     PARSE_OPT_KEEP_ARGV0 | PARSE_OPT_KEEP_UNKNOWN |
@@ -358,6 +360,11 @@ static int git_log_config(const char *var, const char *value, void *cb)
 	}
 	if (!prefixcmp(var, "color.decorate."))
 		return parse_decorate_color_config(var, 15, value);
+	if (!strcmp(var, "log.mailmap")) {
+		use_mailmap_config = git_config_bool(var, value);
+		return 0;
+	}
+
 	if (grep_config(var, value, cb) < 0)
 		return -1;
 	return git_diff_ui_config(var, value, cb);
diff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh
index e16187f..7d4d31c 100755
--- a/t/t4203-mailmap.sh
+++ b/t/t4203-mailmap.sh
@@ -255,6 +255,21 @@ test_expect_success 'Log output with --use-mailmap' '
 '
 
 cat >expect <<\EOF
+Author: CTO <cto@company.xx>
+Author: Santa Claus <santa.claus@northpole.xx>
+Author: Santa Claus <santa.claus@northpole.xx>
+Author: Other Author <other@author.xx>
+Author: Other Author <other@author.xx>
+Author: Some Dude <some@dude.xx>
+Author: A U Thor <author@example.com>
+EOF
+
+test_expect_success 'Log output with log.mailmap' '
+	git -c log.mailmap=True log | grep Author >actual &&
+	test_cmp expect actual
+'
+
+cat >expect <<\EOF
 Author: Santa Claus <santa.claus@northpole.xx>
 Author: Santa Claus <santa.claus@northpole.xx>
 EOF
@@ -263,6 +278,15 @@ test_expect_success 'Grep author with --use-mailmap' '
 	git log --use-mailmap --author Santa | grep Author >actual &&
 	test_cmp expect actual
 '
+cat >expect <<\EOF
+Author: Santa Claus <santa.claus@northpole.xx>
+Author: Santa Claus <santa.claus@northpole.xx>
+EOF
+
+test_expect_success 'Grep author with log.mailmap' '
+	git -c log.mailmap=True log --author Santa | grep Author >actual &&
+	test_cmp expect actual
+'
 
 >expect
 
-- 
1.7.12.4.3.g2036a08.dirty
Previous: Antoine Pelisse
Message 14 of 14 in “Log mailmap optimization”
  1. 00/10 Log mailmap optimizationAntoine Pelisse, Jan 5, 2013
  2. 01/10 list_lookup: create case and length searchAntoine Pelisse, Jan 5, 2013
  3. Junio C HamanoJan 5, 2013
  4. Junio C HamanoJan 7, 2013
  5. 02/10 Use split_ident_line to parse author and committerAntoine Pelisse, Jan 5, 2013
  6. 03/10 mailmap: remove email copy and length limitationAntoine Pelisse, Jan 5, 2013
  7. 04/10 mailmap: simplify map_user() interfaceAntoine Pelisse, Jan 5, 2013
  8. Junio C HamanoJan 6, 2013
  9. 05/10 mailmap: add mailmap structure to rev_info and ppAntoine Pelisse, Jan 5, 2013
  10. 06/10 pretty: use mailmap to display username and emailAntoine Pelisse, Jan 5, 2013
  11. 07/10 log: add --use-mailmap optionAntoine Pelisse, Jan 5, 2013
  12. 08/10 test: add test for --use-mailmap optionAntoine Pelisse, Jan 5, 2013
  13. 09/10 log: grep author/committer using mailmapAntoine Pelisse, Jan 5, 2013
  14. 10/10 log: add log.mailmap configuration optionAntoine Pelisse, Jan 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.