git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 03/10] wildmatch: replace variable 'special' with better named ones

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Jan 1, 2013, 02:44 UTC
Message-ID
<1357008251-10014-4-git-send-email-pclouds@gmail.com>
In-Reply-To
<1357008251-10014-1-git-send-email-pclouds@gmail.com>

'special' is too generic and is used for two different purposes. Replace it with 'match_slash' to indicate "**" pattern and 'negated' for "[!...]" and "[^...]".

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 wildmatch.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/wildmatch.c b/wildmatch.c
index 5f976e9..2d3ed84 100644
--- a/wildmatch.c
+++ b/wildmatch.c
@@ -61,7 +61,7 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
 	const uchar *pattern = p;
 
 	for ( ; (p_ch = *p) != '\0'; text++, p++) {
-		int matched, special;
+		int matched, match_slash, negated;
 		uchar t_ch, prev_ch;
 		if ((t_ch = *text) == '\0' && p_ch != '*')
 			return ABORT_ALL;
@@ -103,15 +103,15 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
 					if (p[0] == '/' &&
 					    dowild(p + 1, text, force_lower_case) == MATCH)
 						return MATCH;
-					special = TRUE;
+					match_slash = TRUE;
 				} else
 					return ABORT_MALFORMED;
 			} else
-				special = FALSE;
+				match_slash = FALSE;
 			if (*p == '\0') {
 				/* Trailing "**" matches everything.  Trailing "*" matches
 				 * only if there are no more slash characters. */
-				if (!special) {
+				if (!match_slash) {
 					if (strchr((char*)text, '/') != NULL)
 						return NOMATCH;
 				}
@@ -121,9 +121,9 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
 				if (t_ch == '\0')
 					break;
 				if ((matched = dowild(p, text,  force_lower_case)) != NOMATCH) {
-					if (!special || matched != ABORT_TO_STARSTAR)
+					if (!match_slash || matched != ABORT_TO_STARSTAR)
 						return matched;
-				} else if (!special && t_ch == '/')
+				} else if (!match_slash && t_ch == '/')
 					return ABORT_TO_STARSTAR;
 				t_ch = *++text;
 			}
@@ -135,8 +135,8 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
 				p_ch = NEGATE_CLASS;
 #endif
 			/* Assign literal TRUE/FALSE because of "matched" comparison. */
-			special = p_ch == NEGATE_CLASS? TRUE : FALSE;
-			if (special) {
+			negated = p_ch == NEGATE_CLASS? TRUE : FALSE;
+			if (negated) {
 				/* Inverted character class. */
 				p_ch = *++p;
 			}
@@ -218,7 +218,7 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
 				} else if (t_ch == p_ch)
 					matched = TRUE;
 			} while (prev_ch = p_ch, (p_ch = *++p) != ']');
-			if (matched == special || t_ch == '/')
+			if (matched == negated || t_ch == '/')
 				return NOMATCH;
 			continue;
 		}
-- 
1.8.0.rc2.23.g1fb49df
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 12 of 19 in “fnmatch replacement”
  1. 00/10 fnmatch replacementNguyễn Thái Ngọc Duy, Jan 1, 2013
  2. 01/10 wildmatch: fix "**" special caseNguyễn Thái Ngọc Duy, Jan 1, 2013
  3. Junio C HamanoJan 22, 2013
  4. Junio C HamanoJan 22, 2013
  5. Duy NguyenJan 23, 2013
  6. Junio C HamanoJan 24, 2013
  7. Duy NguyenJan 24, 2013
  8. Junio C HamanoJan 24, 2013
  9. Duy NguyenJan 25, 2013
  10. Junio C HamanoJan 25, 2013
  11. 02/10 compat/fnmatch: respect NO_FNMATCH* even on glibcNguyễn Thái Ngọc Duy, Jan 1, 2013
  12. 03/10 wildmatch: replace variable 'special' with better named onesNguyễn Thái Ngọc Duy, Jan 1, 2013
  13. 04/10 wildmatch: rename constants and update prototypeNguyễn Thái Ngọc Duy, Jan 1, 2013
  14. 05/10 wildmatch: make dowild() take arbitrary flagsNguyễn Thái Ngọc Duy, Jan 1, 2013
  15. 06/10 wildmatch: support "no FNM_PATHNAME" modeNguyễn Thái Ngọc Duy, Jan 1, 2013
  16. 07/10 test-wildmatch: add "perf" command to compare wildmatch and fnmatchNguyễn Thái Ngọc Duy, Jan 1, 2013
  17. 08/10 wildmatch: make a special case for "*/" with FNM_PATHNAMENguyễn Thái Ngọc Duy, Jan 1, 2013
  18. 09/10 wildmatch: advance faster in <asterisk> + <literal> patternsNguyễn Thái Ngọc Duy, Jan 1, 2013
  19. 10/10 Makefile: add USE_WILDMATCH to use wildmatch as fnmatchNguyễn Thái Ngọc Duy, Jan 1, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.