git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholder

From
David Aguilar <davvid@gmail.com>
Date
Dec 20, 2012, 04:45 UTC
Message-ID
<1355978754-7041-1-git-send-email-davvid@gmail.com>

Use mktemp to create the /dev/null placeholder for p4merge. This keeps it out of the current directory.

Reported-by: Jeremy Morton <admin@game-point.net>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
I consider this a final finishing touch on a new 1.8.1 feature,
so hopefully we can get this in before 1.8.1.
 mergetools/p4merge | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/mergetools/p4merge b/mergetools/p4merge
index 295361a..090fa9b 100644
--- a/mergetools/p4merge
+++ b/mergetools/p4merge
@@ -4,13 +4,13 @@ diff_cmd () {
 	rm_remote=
 	if test "/dev/null" = "$LOCAL"
 	then
-		LOCAL="./p4merge-dev-null.LOCAL.$$"
+		LOCAL="$(create_empty_file)"
 		>"$LOCAL"
 		rm_local=true
 	fi
 	if test "/dev/null" = "$REMOTE"
 	then
-		REMOTE="./p4merge-dev-null.REMOTE.$$"
+		REMOTE="$(create_empty_file)"
 		>"$REMOTE"
 		rm_remote=true
 	fi
@@ -33,3 +33,7 @@ merge_cmd () {
 	"$merge_tool_path" "$BASE" "$LOCAL" "$REMOTE" "$MERGED"
 	check_unchanged
 }
+
+create_empty_file () {
+	mktemp -t git-difftool-p4merge-empty-file.XXXXXX
+}
-- 
1.8.1.rc2.6.g18499ba
Next: Junio C Hamano
Message 1 of 5 in “mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholder”
  1. mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholderDavid Aguilar, Dec 20, 2012
  2. Junio C HamanoDec 20, 2012
  3. Junio C HamanoDec 20, 2012
  4. David AguilarDec 20, 2012
  5. Joachim SchmitzDec 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.