git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 p1.1 02/14] remote-testgit: fix direction of marks

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 24, 2012, 03:17 UTC
Message-ID
<1353727034-24698-3-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1353727034-24698-1-git-send-email-felipe.contreras@gmail.com>
Basically this is what we want:
  == pull ==
	testgit			transport-helper
	* export ->		import
	# testgit.marks		git.marks
  == push ==
	testgit			transport-helper
	* import		<- export
	# testgit.marks		git.marks

Each side should be agnostic of the other side. Because testgit.marks (our helper marks) could be anything, not necessarily a format parsable by fast-export or fast-import. In this test they happen to be compatible, because we use those tools, but in the real world it would be something completely different. For example, they might be mapping marks to mercurial revisions (certainly not parsable by fast-import/export).

This is what we have:
  == pull ==
	testgit			transport-helper
	* export ->		import
	# testgit.marks		git.marks
  == push ==
	testgit			transport-helper
	* import		<- export
	# git.marks		testgit.marks

The only reason this is working is that git.marks and testgit.marks are roughly the same.

This new behavior used to not be possible before due to a bug in fast-export, but with the bug fixed, it works fine.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 git-remote-testgit.py              | 2 +-
 git_remote_helpers/git/importer.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-remote-testgit.py b/git-remote-testgit.py
index 5f3ebd2..ade797b 100644
--- a/git-remote-testgit.py
+++ b/git-remote-testgit.py
@@ -91,7 +91,7 @@ def do_capabilities(repo, args):
     if not os.path.exists(dirname):
         os.makedirs(dirname)
 
-    path = os.path.join(dirname, 'testgit.marks')
+    path = os.path.join(dirname, 'git.marks')
 
     print "*export-marks %s" % path
     if os.path.exists(path):
diff --git a/git_remote_helpers/git/importer.py b/git_remote_helpers/git/importer.py
index 5c6b595..e28cc8f 100644
--- a/git_remote_helpers/git/importer.py
+++ b/git_remote_helpers/git/importer.py
@@ -39,7 +39,7 @@ class GitImporter(object):
             gitdir = self.repo.gitpath
         else:
             gitdir = os.path.abspath(os.path.join(dirname, '.git'))
-        path = os.path.abspath(os.path.join(dirname, 'git.marks'))
+        path = os.path.abspath(os.path.join(dirname, 'testgit.marks'))
 
         if not os.path.exists(dirname):
             os.makedirs(dirname)
-- 
1.8.0
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 18 in “fast-export and remote-testgit improvements”
  1. 00/14 fast-export and remote-testgit improvementsFelipe Contreras, Nov 24, 2012
  2. 01/14 fast-export: avoid importing blob marksFelipe Contreras, Nov 24, 2012
  3. 02/14 remote-testgit: fix direction of marksFelipe Contreras, Nov 24, 2012
  4. 03/14 remote-helpers: fix failure messageFelipe Contreras, Nov 24, 2012
  5. 04/14 Rename git-remote-testgit to git-remote-testpyFelipe Contreras, Nov 24, 2012
  6. 05/14 Add new simplified git-remote-testgitFelipe Contreras, Nov 24, 2012
  7. 06/14 remote-testgit: remove non-local functionalityFelipe Contreras, Nov 24, 2012
  8. 07/14 remote-testgit: remove irrelevant testFelipe Contreras, Nov 24, 2012
  9. 08/14 remote-testgit: cleanup testsFelipe Contreras, Nov 24, 2012
  10. 09/14 remote-testgit: exercise more featuresFelipe Contreras, Nov 24, 2012
  11. 10/14 remote-testgit: report success after an importFelipe Contreras, Nov 24, 2012
  12. 11/14 remote-testgit: implement the "done" feature manuallyFelipe Contreras, Nov 24, 2012
  13. 12/14 fast-export: trivial cleanupFelipe Contreras, Nov 24, 2012
  14. 13/14 fast-export: fix comparison in testsFelipe Contreras, Nov 24, 2012
  15. 14/14 fast-export: make sure updated refs get updatedFelipe Contreras, Nov 24, 2012
  16. Junio C HamanoNov 26, 2012
  17. Felipe ContrerasNov 26, 2012
  18. Junio C HamanoNov 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.