Re: [EGIT] [PATCH v1 1/1] Add an ignored icon

From: Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date: Feb 24, 2009, 09:22 UTC
Message-ID: <13520.77.61.241.211.1235467365.squirrel@hupie.xs4all.nl>
In-Reply-To: <49A3BCA3.8010201@gmail.com>

Show 14 quoted lines

>> I just checked, TortoiseSVN has the overlay for ignored items on by default
>
> The difference is TortoiseSVN does not come with a set of global default
> ignored files (as far as I know). Eclipse does, see Team->Ignored...
>
> So, a globally ignored file such as foobar.BAK would show up as
> non-decorated if shared using the CVS or SVN plugins, but with an icon
> if shared with Git. That might be confusing to users, especially since
> the minus-sign icon does not have any history in Eclipse as something
> being "ignored" (it actually breaks the convention of using
> non-decoration -- meaning no "untracked"-icon -- to signal ignored).
>
> So, I would still argue that we should leave it off by default.
>

For now I think that's acceptable. However, when I complete the work on the ignores then we should switch it on: I plan to let EGit NOT look at the Eclipse global ignore list because the ignores are defined by .gitignore files for git repositories. At that point it totally makes sense to decorate ignored resources because these are configured in .gitignore files